Improve local only sync

gradle/libs.versions.toml

@@ -22,6 +22,7 @@ koin = "4.0.4"
 coil = "3.2.0"
 about-libraries = "12.2.0"
 mockito = "5.18.0"
+mockito-kotlin = "5.4.0"
 kover = "0.9.1"
 androidx-test-runner = "1.6.2"
 
@@ -95,6 +96,7 @@ androidx-ui-test-junit4 = { module = "androidx.compose.ui:ui-test-junit4", versi
 androidx-test-runner = { module = "androidx.test:runner", version.ref = "androidx-test-runner" }
 
 mockito-core = { module = "org.mockito:mockito-core", version.ref = "mockito" }
+mockito-kotlin = { module = "org.mockito.kotlin:mockito-kotlin", version.ref = "mockito-kotlin" }
 
 androidx-ui-tooling-preview-android = { module = "androidx.compose.ui:ui-tooling-preview-android", version.ref = "compose" }
 androidx-ui-tooling = { module = "androidx.compose.ui:ui-tooling", version.ref = "compose" }
@@ -115,6 +117,7 @@ coil = ["coil-compose", "coil-network"]
 
 mockito = [
     "mockito-core",
+    "mockito-kotlin",
 ]
 
 [plugins]

tasks-app-shared/src/commonTest/kotlin/net/opatry/tasks/data/TaskRepositorySyncTest.kt → tasks-app-shared/src/commonTest/kotlin/net/opatry/tasks/data/TaskRepositorySyncIntegrationTest.kt

@@ -33,21 +33,19 @@ import kotlin.test.assertEquals
 import kotlin.test.assertNotNull
 
 
-class TaskRepositorySyncTest {
+class TaskRepositorySyncIntegrationTest {
     @Test
-    fun `sync remote task lists`() {
+    fun `when remote task lists with tasks then sync should store data locally`() {
         val taskListsApi = InMemoryTaskListsApi("My tasks", "Other tasks")
         val tasksApi = InMemoryTasksApi("1" to listOf("First task TODO"), "2" to listOf("Another task"))
 
         runTaskRepositoryTest(taskListsApi, tasksApi) { repository ->
             val initialTaskLists = repository.getTaskLists().firstOrNull()
             assertEquals(0, initialTaskLists?.size, "There shouldn't be any task list at start")
 
-            repository.sync()
+            repository.sync(cleanStaleTasks = false)
 
-            assertEquals(1, taskListsApi.requestCount)
             assertContentEquals(listOf("list"), taskListsApi.requests)
-            assertEquals(2, tasksApi.requestCount)
             assertContentEquals(listOf("list", "list"), tasksApi.requests)
 
             val taskLists = repository.getTaskLists().firstOrNull()
@@ -66,7 +64,7 @@ class TaskRepositorySyncTest {
     }
 
     @Test
-    fun `task list CRUD without network should create a local only task list`() {
+    fun `when network is OFF then created task list should be local only`() {
         val taskListsApi = InMemoryTaskListsApi()
 
         runTaskRepositoryTest(taskListsApi) { repository ->
@@ -80,10 +78,11 @@ class TaskRepositorySyncTest {
     }
 
     @Test
-    fun `local only task lists are synced at next sync`() {
-        val taskListsApi = InMemoryTaskListsApi()
+    fun `when there are local only task lists then sync should upload them`() {
+        val taskListsApi = InMemoryTaskListsApi("Task list")
+        val tasksApi = InMemoryTasksApi()
 
-        runTaskRepositoryTest(taskListsApi) { repository ->
+        runTaskRepositoryTest(taskListsApi, tasksApi) { repository ->
             // for first request, no network
             taskListsApi.isNetworkAvailable = false
             repository.createTaskList("Task list")
@@ -93,9 +92,9 @@ class TaskRepositorySyncTest {
 
             // network is considered back, sync should trigger fetch & push requests
             taskListsApi.isNetworkAvailable = true
-            repository.sync()
-            assertEquals(2, taskListsApi.requestCount)
+            repository.sync(cleanStaleTasks = false)
             assertContentEquals(listOf("list", "insert"), taskListsApi.requests)
+            assertContentEquals(listOf("list"), tasksApi.requests)
         }
     }
 }

tasks-app-shared/src/commonTest/kotlin/net/opatry/tasks/data/util/InMemoryTasksApi.kt

@@ -154,7 +154,7 @@ class InMemoryTasksApi(
         return handleRequest("list") {
             // TODO maxResults & token handling
             val tasks = synchronized(this) {
-                storage[taskListId] ?: error("Task list ($taskListId) not found")
+                storage[taskListId] ?: emptyList()
             }
             val filteredTasks = tasks.filter { task ->
                 // Check if completed tasks should be shown

tasks-core/build.gradle.kts

@@ -45,6 +45,10 @@ kotlin {
 
         commonTest.dependencies {
             implementation(kotlin("test"))
+
+            implementation(libs.kotlinx.coroutines.test)
+
+            implementation(libs.bundles.mockito)
         }
     }
 }