You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Presets don't re-apply pill glyphs when applying Yes/No values
Presets that change other presets are buggy (nested presets would be very handy)
Works somewhat if the child preset is after the parent preset
However the child preset remains greyed out even if changed afterwards
Child presets before the parent preset don't update their values correctly (it takes another round of saving).
Presets don't need options since the labels are already in the presets table
Or you could do it the other way around - have the presets table in options and remove the presets property
This might be a good precursor to allowing options that have labels different to their values - if it's a string then split it, if it's a table then use key/value pairs...
Presets are mixing json syntax with table syntax, which is valid but may be confusing
json: "Preset 0" : {...}
table: ["Preset 0"] = {...}
The majority of Squirrel code I've seen has used table syntax
An enum for the option opaque values might be better than supporting comments // 1=is_input, 2=is_function, 3=is_preset
There's "magic" opaque values everywhere - should be on our todo list...
Presets don't re-apply pill glyphs when applying Yes/No values
I'll look into it
Presets that change other presets are buggy (nested presets would be very handy)
Nesting was just an idea after I pushed this PR, so I'm not surprised it does not work.
Presets don't need options since the labels are already in the presets table
Or you could do it the other way around - have the presets table in options and remove the presets property
This might be a good precursor to allowing options that have labels different to their values - if it's a string then split it, if it's a table then use key/value pairs...
It's a good idea.
Presets are mixing json syntax with table syntax, which is valid but may be confusing
I personally prefer json syntax so I can have spaces in the name and there is no need for square brackets. Further discussion needed.
An enum for the option opaque values might be better than supporting comments // 1=is_input, 2=is_function, 3=is_preset
I've come up with the same conclusion, but left it for later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test layout:
layout-presets.nut.txt
Needs to be thoroughly tested. I'm not going to insist on adding it to 3.2.0