-
Notifications
You must be signed in to change notification settings - Fork 4
V2 #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
onhernandes
wants to merge
23
commits into
main
Choose a base branch
from
v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
V2 #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 MAJOR: Full TypeScript rewrite with modern tooling ## Core Migration - Convert all JavaScript files to TypeScript with strict typing - Migrate Parser class with proper interfaces and generics - Convert all strategy classes (JSON, CSV, YAML, XML) to TypeScript - Rewrite error classes with proper inheritance ## New Architecture - Add comprehensive type definitions in src/types/ - Implement IStrategy and IParser interfaces - Create abstract Base class with proper method signatures - Add format-specific option types (CsvParseOptions, YamlStringifyOptions, etc.) ## Modern Development Setup - Replace ESLint with Prettier for code formatting - Update to TypeScript 5.2.2 with strict configuration - Modernize Jest setup with ts-jest for TypeScript testing - Add TypeScript build pipeline generating declarations + source maps ## Updated Dependencies - Upgrade csv-parse (^4.11.1 → ^5.5.2) - Upgrade csv-stringify (^5.5.0 → ^6.4.4) - Upgrade js-yaml (^3.14.0 → ^4.1.0) - Add @types packages for full TypeScript support - Update engines to Node 16+ for modern JS features ## Developer Experience - Add comprehensive IntelliSense support - Include proper type checking with zero TypeScript errors - Maintain backward-compatible API (same simple usage) - Add build scripts: build, dev, test:watch, format ## Build Output - Generate dist/ with compiled JavaScript + TypeScript declarations - Include source maps for debugging - Configure package.json main/types fields properly ## Cleanup - Remove all legacy JavaScript files - Update .gitignore for TypeScript build outputs - Clean project structure with proper separation ✅ Successfully builds with no TypeScript errors ✅ Basic functionality verified and working ✅ Ready for v2 feature development BREAKING CHANGE: Requires Node.js 16+ and TypeScript for development
…vert all test files from JavaScript to TypeScript - Replace require() statements with modern import statements - Add proper TypeScript type annotations - Fix stream event handling - All 52 tests passing with 6 skipped streaming tests
- Add cursor rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.