💥 introduced register-unregister wallet in identity #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgonday
requested changes
Jan 5, 2026
contracts/factory/IdFactory.sol
Outdated
| import { KeyTypes } from "../libraries/KeyTypes.sol"; | ||
|
|
||
| contract IdFactory is IIdFactory, Ownable { | ||
| using ECDSA for bytes32; |
Collaborator
There was a problem hiding this comment.
Unneeded as you are using ECDSA.* syntax
contracts/factory/IdFactory.sol
Outdated
| bytes calldata signature, | ||
| uint256 expiry | ||
| ) external override { | ||
| if (wallet == address(0)) { |
Collaborator
There was a problem hiding this comment.
Use require
I don't understand this mlx of if...revert and require ??
contracts/factory/IdFactory.sol
Outdated
| if (wallet == address(0)) { | ||
| revert Errors.ZeroAddress(); | ||
| } | ||
| if (block.timestamp > expiry) { |
contracts/factory/IdFactory.sol
Outdated
| revert Errors.ZeroAddress(); | ||
| } | ||
| if (block.timestamp > expiry) { | ||
| revert Errors.SignatureExpired(expiry); |
Collaborator
There was a problem hiding this comment.
use existing error ExpiredSignature
contracts/factory/IdFactory.sol
Outdated
| abi.encode(wallet, identity, expiry, address(this), block.chainid) | ||
| ); | ||
|
|
||
| address signer = _recoverWalletSigner(structHash, signature); |
Collaborator
There was a problem hiding this comment.
unneeded orphan internal function, inline
contracts/factory/IdFactory.sol
Outdated
| * @dev See {IdFactory-unregisterWalletFromIdentity}. | ||
| */ | ||
| function unregisterWalletFromIdentity(address wallet) external override { | ||
| if (wallet == address(0)) { |
contracts/factory/IdFactory.sol
Outdated
| if (wallet == address(0)) { | ||
| revert Errors.ZeroAddress(); | ||
| } | ||
| if (_userIdentity[wallet] != msg.sender) { |
contracts/factory/IdFactory.sol
Outdated
| revert Errors.ZeroAddress(); | ||
| } | ||
| if (_userIdentity[wallet] != msg.sender) { | ||
| revert Errors.WalletNotLinked(); |
Collaborator
There was a problem hiding this comment.
use existing error WalletNotLinkedToIdentity
contracts/factory/IdFactory.sol
Outdated
| bytes32 structHash, | ||
| bytes calldata signature | ||
| ) internal pure returns (address) { | ||
| bytes32 digest = keccak256( |
Collaborator
There was a problem hiding this comment.
use MessageHashUtils.toEthSignedMessageHash
Collaborator
There was a problem hiding this comment.
Some branches are not covered (3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.