fix: Vue reactivity for adapter status and enable skipped tests #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irty forms The Online/Offline status chip was not updating when: 1. User had unsaved form changes (dirty form) 2. Network cable was removed (adapter went offline) Root Cause: - NetworkSettings.vue watcher had early return when form dirty - This blocked Vue's reactivity dependency tracking - Template couldn't re-evaluate props.networkAdapter.online changes - Bug was latent but exposed when :key was added to v-window-item Solution: - Allow watcher to execute even when form is dirty - Only conditionally call resetFormFields() when form is clean - This maintains Vue's reactivity tracking for non-form props Also includes: - Test refactoring: consolidated network tests into 2 files - Core validation to prevent hidden components from sending updates - 5 new regression tests for online/offline status updates - Fix for rollback modal appearing on wrong adapters Tests: 46 passing, 1 skipped (fixme) Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
Fixed two previously skipped tests:
1. Rust unit test: tick_increments_attempt_counter
- Removed #[ignore] attribute
- Test verifies that new IP healthcheck attempts increment counter
- Added explicit panic for unexpected state to improve test clarity
2. E2E test: Rollback modal should close on second apply after a rollback
- Removed test.fixme() annotation and FIXME comments
- Fixed flaky re-login logic after rollback acknowledgment
- Added proper state cleanup: navigate to '/' instead of reload
- Handle persistent rollback dialog after page navigation
- Reset browser hostname after reload to restore current connection
- Add explicit waits for Core/Centrifugo initialization
- Use separate variables (confirmDialog2, rollbackCheckbox2) for
second network change to avoid scope issues
- Clear input field before filling to ensure change detection
All tests now pass reliably.
Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
JanZachmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes two related fixes for the network configuration system:
1. Fix Vue Reactivity for Adapter Online/Offline Status with Dirty Forms
Issue: The Online/Offline status chip was not updating when the user had unsaved form changes and the network cable was removed.
Root Cause:
NetworkSettings.vuewatcher had an early return when form was dirtyprops.networkAdapter.onlinechanges:keywas added tov-window-itemSolution:
resetFormFields()when form is cleanAdditional Improvements:
network-configuration.spec.tsandnetwork-multi-adapter.spec.ts)2. Enable Previously Skipped Tests
Rust Unit Test:
tick_increments_attempt_countersrc/app/src/update/device/network/verification.rs#[ignore]due to difficulty verifying HTTP effectsE2E Test: "Rollback modal should close on second apply after a rollback"
src/ui/tests/network-configuration.spec.tstest.fixme()due to flaky re-login logic and persistent error snackbars after rollbackSigned-off-by: Jan Zachmann 50990105+JanZachmann@users.noreply.github.com