feat: complete Crux Core migration with full E2E test coverage

README.md

@@ -101,13 +101,16 @@ omnect-ui/
 ├── src/
 │   ├── backend/          # Rust backend (Actix-web)
 │   ├── app/              # Crux Core (business logic)
+│   │   ├── src/
+│   │   │   ├── commands/ # Custom side-effect commands
+│   │   │   └── ...
 │   ├── shared_types/     # TypeGen for TypeScript bindings
 │   └── ui/               # Vue 3 frontend
 ├── scripts/              # Build and development scripts
 │   └── build-frontend.sh # Build WASM + TypeScript types + UI
+│   └── setup-centrifugo.sh  # Download script for Centrifugo
 ├── tools/                # Development tools
 │   ├── centrifugo        # WebSocket server binary (gitignored)
-│   └── setup-centrifugo.sh  # Download script for Centrifugo
 ├── Dockerfile            # Multi-stage Docker build
 └── build-and-deploy-image.sh  # Build and deployment script
 ```

scripts/run-e2e-tests.sh

@@ -3,6 +3,10 @@ set -e
 
 # Internal script to run E2E tests inside the container
 
+# Navigate to repository root (parent of scripts directory)
+REPO_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+cd "$REPO_ROOT"
+
 # Cleanup function to kill spawned processes
 cleanup() {
     echo "🧹 Cleaning up processes..."
@@ -20,22 +24,14 @@ pkill -9 -f "bun run.*5173" 2>/dev/null || true
 pkill -9 -f "node.*vite.*5173" 2>/dev/null || true
 sleep 2
 
-# 1. Ensure bun is installed (needed for UI)
+# 1. Ensure bun is installed (needed for building and running UI)
 if ! command -v bun &> /dev/null; then
-    echo "⚠️ Bun not found, installing..."
-    curl -fsSL https://bun.sh/install | bash
-    export BUN_INSTALL="$HOME/.bun"
-    export PATH="$BUN_INSTALL/bin:$PATH"
+    echo "❌ bun not found in PATH."
+    exit 1
 fi
 
-# 2. Ensure Centrifugo is available (using the tool script if needed)
-if ! command -v centrifugo &> /dev/null; then
-    echo "⚠️ Centrifugo not found in PATH, checking tools directory..."
-    if [ ! -f "tools/centrifugo" ]; then
-        ./tools/setup-centrifugo.sh
-    fi
-    export PATH=$PATH:$(pwd)/tools
-fi
+# 2. Ensure Centrifugo is available
+./scripts/setup-centrifugo.sh
 
 # 3. Start Centrifugo directly (Backend is mocked, but we need real WS)
 echo "🚀 Starting Centrifugo..."
@@ -65,7 +61,7 @@ export CENTRIFUGO_CLIENT_TOKEN_HMAC_SECRET_KEY="secret"
 export CENTRIFUGO_HTTP_API_KEY="api_key"
 export CENTRIFUGO_LOG_LEVEL="info"
 
-centrifugo -c "$CENTRIFUGO_CONFIG" > /tmp/centrifugo.log 2>&1 &
+./tools/centrifugo -c "$CENTRIFUGO_CONFIG" > /tmp/centrifugo.log 2>&1 &
 CENTRIFUGO_PID=$!
 
 echo "⏳ Waiting for Centrifugo..."
@@ -106,6 +102,12 @@ fi
 # Build the frontend for preview mode (eliminates Vite dev optimization issues)
 # Note: Using default base path (/) for preview server, not /static for production backend
 echo "🏗️  Building frontend..."
+# Faster polling for E2E tests
+export VITE_RECONNECTION_POLL_INTERVAL_MS=500
+export VITE_NEW_IP_POLL_INTERVAL_MS=500
+export VITE_REBOOT_TIMEOUT_MS=2000
+export VITE_FACTORY_RESET_TIMEOUT_MS=500
+
 if bun run build-preview > /tmp/vite-build.log 2>&1; then
     echo "✅ Frontend build complete!"
 else

tools/setup-centrifugo.sh → scripts/setup-centrifugo.sh

@@ -3,10 +3,17 @@
 
 set -e
 
+# Navigate to repository root (parent of scripts directory)
+REPO_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+cd "$REPO_ROOT"
+
 CENTRIFUGO_VERSION="${CENTRIFUGO_VERSION:-v6.1.0}"
-SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+SCRIPT_DIR="tools"
 CENTRIFUGO_BIN="$SCRIPT_DIR/centrifugo"
 
+# Create directory if it doesn't exist
+mkdir -p "$SCRIPT_DIR"
+
 if [[ -f "$CENTRIFUGO_BIN" ]]; then
   echo "Centrifugo already exists at $CENTRIFUGO_BIN"
   "$CENTRIFUGO_BIN" version 2>/dev/null || true

scripts/test-e2e-in-container.sh

@@ -3,7 +3,11 @@ set -e
 
 # Host script to run E2E tests inside the docker container
 
-IMAGE="omnectshareddevacr.azurecr.io/rust:bookworm"
+# Navigate to repository root (parent of scripts directory)
+REPO_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+cd "$REPO_ROOT"
+
+IMAGE="omnectweucopsacr.azurecr.io/rust:bookworm"
 
 echo "🐳 Launching test container..."
 
@@ -14,9 +18,9 @@ if [ ! -d "src/ui/dist" ]; then
 fi
 
 # Run the test script inside the container
-# We mount the current directory to /workspace
+# We mount the repository root to /workspace
 docker run --rm \
-    -v $(pwd):/workspace \
+    -v "$REPO_ROOT":/workspace \
     -w /workspace \
     --net=host \
     $IMAGE \

src/app/Cargo.toml

@@ -23,13 +23,15 @@ unexpected_cfgs = { level = "warn", check-cfg = ['cfg(feature, values("facet_typ
 [dependencies]
 base64 = { version = "0.22", default-features = false, features = ["alloc"] }
 console_log = { version = "1.0", default-features = false }
-crux_core = { version = "0.16", default-features = false }
-crux_http = { version = "0.15", default-features = false }
+crux_core = { version = "0.17.0-rc2" }
+crux_http = { version = "0.16.0-rc2", default-features = false }
+crux_macros = { version = "0.8.0-rc2" }
 lazy_static = { version = "1.4", default-features = false }
 log = { version = "0.4", default-features = false }
+getrandom = { version = "0.3", features = ["wasm_js"] }
 serde = { version = "1.0", default-features = false, features = ["derive"] }
 serde_json = { version = "1.0", default-features = false }
 wasm-bindgen = { version = "0.2", default-features = false }
 
 [build-dependencies]
-crux_core = { version = "0.16", default-features = false, features = ["typegen"] }
+crux_core = { version = "0.17.0-rc2", default-features = false, features = ["typegen"] }

src/app/README.md

@@ -9,11 +9,11 @@ The Crux Core follows the Model-View-Update pattern:
 - **Model** - The complete application state (auth, device info, network status, etc.)
 - **ViewModel** - Data needed by the UI to render
 - **Events** - Actions that can occur in the application
-- **Capabilities** - Side effects (HTTP requests, WebSocket, rendering)
+- **Effects** - Side effects (HTTP requests, WebSocket, rendering)
 
 ## Key Files
 
-- `src/lib.rs` - App struct, Capabilities, and re-exports
+- `src/lib.rs` - App struct, Effect enum, and re-exports
 - `src/model.rs` - Model and ViewModel structs
 - `src/events.rs` - Event enum definitions
 - `src/types/` - Domain-based type definitions
@@ -31,12 +31,15 @@ The Crux Core follows the Model-View-Update pattern:
   - `device/` - Device action handlers
     - `mod.rs` - Device event dispatcher
     - `operations.rs` - Device operations (reboot, factory reset, updates)
-    - `network.rs` - Network configuration handlers
     - `reconnection.rs` - Device reconnection handlers
+    - `network/` - Network configuration handlers
+      - `mod.rs` - Module re-exports
+      - `config.rs` - Network config request/response
+      - `form.rs` - Form state management
+      - `verification.rs` - IP check and rollback logic
   - `websocket.rs` - WebSocket/Centrifugo handlers
   - `ui.rs` - UI action handlers (clear error/success)
-- `src/capabilities/centrifugo.rs` - Custom WebSocket capability (deprecated API, kept for Effect enum generation)
-- `src/capabilities/centrifugo_command.rs` - Command-based WebSocket capability (new API)
+- `src/commands/centrifugo.rs` - Custom WebSocket commands
 
 ## Building
 
@@ -97,20 +100,6 @@ const errorMessage = computed(() => viewModel.error_message)
 5. Effects are processed (HTTP requests, render updates, etc.)
 6. ViewModel is updated and Vue re-renders
 
-## Capabilities
-
-### Render
-
-Updates the ViewModel to trigger UI re-rendering.
-
-### HTTP
-
-Makes REST API calls to the backend. The shell handles the actual HTTP request and sends the response back to the core.
-
-### Centrifugo
-
-Manages WebSocket subscriptions for real-time updates. The shell handles the actual WebSocket connection.
-
 ## Testing
 
 The core includes unit tests for business logic:
@@ -129,12 +118,8 @@ cargo clippy -p omnect-ui-core -- -D warnings
 
 **Additional Tasks:**
 
-- [ ] Add comprehensive integration tests for all migrated components
-- [ ] Add more unit tests for Core edge cases
-- [ ] Performance testing and bundle size optimization
+- [ ] Performance bundle size optimization
 
 ### Technical Debt
 
-- [ ] Remove deprecated capabilities once crux_core provides alternative Effect generation mechanism
 - [ ] Refactor `Model.auth_token` to not be serialized to the view model directly. The current approach of removing `#[serde(skip_serializing)]` in `src/app/src/model.rs` is a workaround for `shared_types` deserialization misalignment. A long-term solution should involve either making TypeGen respect `skip_serializing` or separating view-specific model fields.
-- [ ] Address `crux_http` error handling for non-2xx HTTP responses: The current implementation uses a workaround (`x-original-status` header in `useCore.ts` and corresponding logic in macros) because `crux_http` (v0.15) appears to discard response bodies for 4xx/5xx status codes, preventing detailed error messages from reaching the Core. This workaround should be removed if future `crux_http` versions provide a more direct way to access error response bodies.