Skip to content

Conversation

@rosle
Copy link
Contributor

@rosle rosle commented Nov 7, 2025

Description

  • Add Typescript support for passkey feature
    • Accept authentication in request parameter - PASSKEY | 3DS
    • Return authenticated_by in the response
  • Add other missing Charge response properties
    • acquirer_reference_number
    • approval_code
    • can_perform_void
    • expired_at
    • funding_amount
    • funding_currency
    • linked_account
    • partially_refundable
    • reversed_at
    • transaction_fees

Please find more info about each properties here - https://docs.omise.co/charges-api

Related links:

https://opn-ooo.atlassian.net/browse/MIT-3611

Rollback procedure

default rollback procedure

@rosle rosle self-assigned this Nov 7, 2025
Base automatically changed from MIT-3611-improve-ts-examples-and-update-deps to master November 11, 2025 02:42
@rosle rosle force-pushed the MIT-3611-support-passkey branch from d12ecb5 to 9814b5b Compare November 11, 2025 02:44
@rosle rosle marked this pull request as ready for review November 11, 2025 02:47
@rosle rosle requested a review from Copilot November 11, 2025 02:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds TypeScript and JavaScript support for the passkey authentication feature, along with several missing Charge API response properties for better API completeness.

  • Introduces the Authentication enum with PASSKEY and 3DS values
  • Adds authentication request parameter and authenticated_by response field to the Charges API
  • Includes 10 additional Charge response properties documented in the Omise API

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
types/index.d.ts Adds Authentication enum, new charge request/response fields, updates export structure to support named exports
index.js Defines enums (Scheme, AuthType, Authentication) and exports them as named exports
examples/typescript/src/create_passkey_charge.ts Provides example demonstrating passkey authentication usage

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rosle rosle merged commit 3f830ae into master Nov 13, 2025
16 checks passed
@rosle rosle deleted the MIT-3611-support-passkey branch November 13, 2025 07:50
@rosle rosle mentioned this pull request Nov 24, 2025
rosle added a commit that referenced this pull request Nov 24, 2025
## Description

- #225 
- #226 

## Rollback procedure

`default rollback procedure`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants