-
Notifications
You must be signed in to change notification settings - Fork 54
[MIT-3611] Add passkey support #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d12ecb5 to
9814b5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds TypeScript and JavaScript support for the passkey authentication feature, along with several missing Charge API response properties for better API completeness.
- Introduces the
Authenticationenum withPASSKEYand3DSvalues - Adds
authenticationrequest parameter andauthenticated_byresponse field to the Charges API - Includes 10 additional Charge response properties documented in the Omise API
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| types/index.d.ts | Adds Authentication enum, new charge request/response fields, updates export structure to support named exports |
| index.js | Defines enums (Scheme, AuthType, Authentication) and exports them as named exports |
| examples/typescript/src/create_passkey_charge.ts | Provides example demonstrating passkey authentication usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
authenticationin request parameter -PASSKEY|3DSauthenticated_byin the responseChargeresponse propertiesacquirer_reference_numberapproval_codecan_perform_voidexpired_atfunding_amountfunding_currencylinked_accountpartially_refundablereversed_attransaction_feesPlease find more info about each properties here - https://docs.omise.co/charges-api
Related links:
https://opn-ooo.atlassian.net/browse/MIT-3611
Rollback procedure
default rollback procedure