Deprecate the S3 interfaces, implementations and services #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work on object storage was added to
ome-commonin version 6.0.0 where #33 added a concrete implemention ofIRandomAccessfor S3 usingio.minio:minioas a new dependency while #39 aS3ClientServiceinterface and itsS3ClientServiceImplimplementation as well .The usage of this API within the OME stack has been limited to the original proof of concept demonstrating remote access data stored as a single file format (TIFF) on public S3 buckets. This workflow is not regularly tested as part of the Bio-Formats development and release process, the
io.minio:miniodependency ships a lot of transitive dependencies which are excluded, is outdated with the latest version requiring new minimal Java versions - see #104.Finally, the Java implementations reading OME-Zarr, OME's cloud format for imaging data, are consuming the AWS SDK for Java directly for accessing the data on AWS S3 or S3 compatible object stores.
For all these reasons discussed at recent OME Formats meeting and as mentioned in #108 (comment), this PR proposes deprecate this S3 API in
ome-common 6in preparation from its removal, currently targeted forome-common 7.0.0and inclusion in Bio-Formats 9.