Remove jackson dependency #109
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Conflicting PR. Removed from build BIOFORMATS-push#704. See the console output for more details.
|
Member
Author
|
Sorry, that should have been a draft PR for now. Luckily it wasn't picked up, guess it would have broken a few downstream builds in merge-build... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially replaces #108 (in order to handle that separetely from the s3 case).
Projects using jackson libs:
https://github.com/search?q=org%3Aome+%22import+com.fasterxml.jackson%22&type=code
I really don't understand how this dependency trickles down to all these projects. Do we need PRs for all of them to declare the dependency explictely after it has been removed from ome-common-java?
Specifically how it trickles down to the server installation, because there's the problem when you want to use omero-zarr-pixelbuffer with latest zarr-java (which is my fault bumping the version there zarr-developers/zarr-java#26 ; I did not expect what a can of worms that opened...)