Skip to content

Conversation

@sluongng
Copy link
Contributor

@sluongng sluongng commented Feb 9, 2022

fixes: #8

Copy link
Owner

@omaskery omaskery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. As per your question on the linked issue: I think that complying with the spec and naming it OtherData would be a good idea, so I'll not mark this as approved yet.

I'd recommend leaving the existing public accessor on TefData as Metadata() though to preserve API compatibility, add a Deprecated: ... comment (as described in here), and just add a new accessor to the same data called OtherData(), then if this ever gets a major version bump we can just delete the Metadata() one.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metadata is never populated

2 participants