Added readStreamOptions#18
Closed
thiagodp wants to merge 1 commit intooleics:masterfrom
thiagodp:add-read-stream-options
Closed
Added readStreamOptions#18thiagodp wants to merge 1 commit intooleics:masterfrom thiagodp:add-read-stream-options
thiagodp wants to merge 1 commit intooleics:masterfrom
thiagodp:add-read-stream-options
Conversation
Owner
|
I like this RM. Can you make it so, that the options for readStream are located in options.readStream with a empty object as default on null/undefined? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to configure the
ReadStream, as mentioned in the Issue 17, it was added an objectreadStreamOptionstofilewalkers constructor:The third parameter is optional and it assumes
fs.createReadStream()'s default values.