add rpi version by Dashlorde · Pull Request #4 · ole-vi/bellapps

Dashlorde · 2018-02-24T02:02:54Z

No description provided.

empeje · 2018-03-09T15:29:04Z

Congratulations

empeje · 2018-03-09T16:09:57Z

Related to #1

empeje

Good work but you need to reduce hardcoded value.

See #3

empeje · 2018-03-13T15:39:50Z

Can you create a screenshot of the working bell docker on the docker.ole.org?
I have limited time to test your setup, but your demonstration will help the review process.

Dashlorde · 2018-03-13T19:58:53Z

I run the bell on docker.ole.org:8080

empeje · 2018-03-14T09:04:14Z

Awesome @Dashlorde

dogi

@Dashlorde good job - added some change wishes

dogi · 2018-03-14T15:45:12Z

arm/bell/dockerfile

+
+RUN mkdir -p /app/server/src && \
+    apk add --update openssl && npm install express && \
+    wget -O BeLL-Apps-${version}.tar.gz \


not needed ...

dogi · 2018-03-14T15:45:26Z

arm/bell/dockerfile

+    wget -O BeLL-Apps-${version}.tar.gz \
+    https://github.com/open-learning-exchange/BeLL-Apps/archive/${version}.tar.gz && \
+    tar xvf BeLL-Apps-${version}.tar.gz && \
+    mv BeLL-Apps-${version}/* /app/server/src/


... until here

dogi · 2018-03-14T15:46:46Z

arm/bell/server.js

+
+PortJack.get(/^(.+)$/, function(req, res) {
+
+    res.setHeader('Location', 'http://' + HOST + ':2200/apps/_design/bell/MyApp/index.html')


please lets not use 2200 port

5984 is couchdb standard

dogi · 2018-03-14T15:48:34Z

arm/bell/dockerfile

@@ -0,0 +1,24 @@
+FROM hypriot/rpi-node:6.10.0-alpine


name of this file should be Dockerfile not dockerfile

dogi · 2018-03-14T15:49:27Z

arm/db-init/couchdb-setup.sh

+fi
+
+# Default port for CouchDB accessed from host machine is 2200
+PORT=${PORT:-2200}


please use for default port 5984

dogi · 2018-03-14T15:50:55Z

arm/docker-compose-ready.yml

+  couchdb:
+    expose:
+      - 5984
+    image: treehouses/rpi-couchdb:2.0.0


please use old couchdb 1.6.1

dogi · 2018-03-14T15:51:20Z

arm/docker-compose-ready.yml

+      - 5984
+    image: treehouses/rpi-couchdb:2.0.0
+    ports:
+      - "2200:5984"


no 2200 just strait 5984

dogi · 2018-03-14T15:51:44Z

arm/docker-compose-ready.yml

+    image: treehouses/rpi-couchdb:2.0.0
+    ports:
+      - "2200:5984"
+      - "2201:5986"


with couchdb 1.6.1 this line is not needed

dogi · 2018-03-14T15:53:08Z

arm/docker-compose.yml

@@ -0,0 +1,21 @@
+services:


same as in arm/docker-compose-ready.yml

dogi · 2018-03-14T15:53:58Z

arm/db-init/dockerfile

@@ -0,0 +1,23 @@
+FROM hypriot/rpi-node:6.10.0-alpine


name of this file should be Dockerfile not dockerfile

Dashlorde added 6 commits February 11, 2018 23:38

add x86 version

598f592

add readme

68728db

update readme

3b3c998

update readme

1057a8b

delete environment

dc2c5f4

add rpi version

d780575

empeje suggested changes Mar 9, 2018

View reviewed changes

Dashlorde added 3 commits March 13, 2018 00:07

use environment variable

1e755ae

delete useless server.js

b046ffd

update dockerfile

9dc9d2b

reduce hardcoded value

badafbe

dogi requested changes Mar 14, 2018

View reviewed changes

Dashlorde added 2 commits March 14, 2018 13:22

change to use port 5984

7104c41

update file name

32a345a


		PortJack.get(/^(.+)$/, function(req, res) {

		res.setHeader('Location', 'http://' + HOST + ':2200/apps/_design/bell/MyApp/index.html')

Conversation

Dashlorde commented Feb 24, 2018

Uh oh!

empeje commented Mar 9, 2018

Uh oh!

empeje commented Mar 9, 2018

Uh oh!

empeje left a comment

Choose a reason for hiding this comment

Uh oh!

empeje commented Mar 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dashlorde commented Mar 13, 2018

Uh oh!

empeje commented Mar 14, 2018

Uh oh!

dogi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

empeje commented Mar 13, 2018 •

edited

Loading