🐛 Clear Document.pdf_file after FoiAttachment redaction#1155
Open
🐛 Clear Document.pdf_file after FoiAttachment redaction#1155
Conversation
stefanw
approved these changes
Nov 17, 2025
Member
stefanw
left a comment
There was a problem hiding this comment.
I do not recall when I introduced get_writeable_file. I thought the concept of original and pdf_file in filingcabinet where mutually exclusive. I thought if there's an original like an attachment, there would be no other stored document. I guess there can be edge cases where you do need one, but I'm a bit concerned that there's logic in filingcabinet that will ignore pdf_file when original is still set – or that when it's not set but there should be a related model. Obviously, that is nothing that can be fixed in froide. If this signal processor helps, let's go!
If the pdf_file is set (for example because the document pdf needed to be rewritten and get_writeable_file was called), it will take precedence over the attachments pdf. This means that new redactions applied to the attachment after pdf_file is set are not shown in the document, as the old version from pdf_file is still used for generating the pages etc.
caf0af1 to
31705bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the pdf_file is set (for example because the document pdf needed to be rewritten and get_writeable_file was called), it will take precedence over the attachments pdf. This means that new redactions applied to the attachment after pdf_file is set are not shown in the document, as the old version from pdf_file is still used for generating the pages etc.