Conversation
Mbodin
force-pushed
the
transform
branch
2 times, most recently
from
6f42a1c to
9a8a009
Compare
Contributor
Author
|
I'm hitting another wall there: according to the spec, it seems that |
Contributor
Author
|
I suggest to remove |
Contributor
Author
|
Is it an issue not to support OCaml version 4.05 or before? |
Member
|
This looks good! Everytime we hit similar issues, I wonder if we shouldn't have a better handling of whitespace in general, but it's pretty tricky in HTML/SVG ...
No. Actually, next version will probably drop everything prior to 4.14. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I followed the specification at https://drafts.csswg.org/css-transforms/#svg-translate as much as I could. As such, I replaced white spaces by the more general
[ \t\r\f].I tried to add some tests. I might not have placed them in the right place (I just noticed the message
This file is here to torture the ppx. Tests that are directly related to html or svg should go to the other files.at the beginning of the file). Maybe some reordering should take place in the test file because of that :-\What do you think?