Conversation
d652f4c to
523c5e6
Compare
Member
Author
|
I just realized this is not really backward compatible, which is mildly annoying to say the least. I'm wondering if anyone is affected except odoc. |
This strengthen a bit the typing for dt, address and header elements that are not supposed to be nested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This strengthen a bit the typing for dt, address and header elements that
are not supposed to be nested.
In particular, this was allowed by tyxml (where it shouldn't):
More importantly (and that's the main reason for actually fixing this),
the coercion
flow5_without_sectioning_heading_header_footer :> flow5_without_header_footerwas failing which was extremely annoying in practice.