Modifies jsonEncodingStream to construct an array#19
Open
reidmiller-geotab wants to merge 1 commit intoocpi:mainfrom
Open
Modifies jsonEncodingStream to construct an array#19reidmiller-geotab wants to merge 1 commit intoocpi:mainfrom
reidmiller-geotab wants to merge 1 commit intoocpi:mainfrom
Conversation
Currently, when using a command like:
node ./dist/index.js get locations
Multiple items are output as:
{ "foo": "bar1"} { "foo": "bar2"}
This is not a syntactically valid array. When piped to jq, as
suggested by the README, something as simple as the following
throws an error:
node ./dist/index.js get locations | jq .
This is due to the array syntax error. The output should be:
[{ "foo": "bar1"} ,{ "foo": "bar2"}]
This commit modifies the jsonEncodingStream to construct
a syntactically valid array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when using a command like:
Multiple items are output as:
This is not a syntactically valid array. When piped to jq, as suggested by the README, something as simple as the following throws an error:
This is due to the array syntax error. The output should be:
This commit modifies the
jsonEncodingStreamto construct a syntactically valid array.I haven't done super thorough testing yet. I think this implementation might be a bit brittle. So far, it's working for me when tested against small collections.