This repository was archived by the owner on Feb 1, 2022. It is now read-only.
Provide proper typings for cli.progress()#438
Open
divideby0 wants to merge 2 commits intooclif:masterfrom
Open
Provide proper typings for cli.progress()#438divideby0 wants to merge 2 commits intooclif:masterfrom
divideby0 wants to merge 2 commits intooclif:masterfrom
Conversation
Hi! 👋
Firstly, thanks for your work on this project! 🙂
At the moment, `cli.progress()` takes an option argument of `any` and returns `any`. This makes it difficult to validate which options are valid and which operations are available on the result of the function.
There may be a reason that `any` is specified here. But if it was an oversight, this PR should resolve the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! 👋
Firstly, thanks for your work on this project! 🙂
At the moment, cli.progress() takes an option argument of any and returns any. This makes it difficult to validate which options are valid and which operations are available on the result of the function.
There may be a reason that any is specified here. But if it was an oversight, this PR should resolve the issue.