Switch from findwinsdk to msvs-detect #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I intentionally haven't updated the AppVeyor matrix to include recent compilers, pending #78 |
The test should be the oldest version supporting the bootstrap (4.03.0), the currently supported versions of OCaml (latest, and latest - 1) and trunk.
dra27
force-pushed
the
msvs-detect-reprised
branch
from
056778d to
8c1176d
Compare
dra27
commented
Apr 11, 2020
| CYG_CACHE: C:/cygwin/var/cache/setup | ||
| matrix: | ||
| - OCAMLBRANCH: 4.03 | ||
| SKIP_OCAML_TEST: no |
Member
Author
There was a problem hiding this comment.
Every PR should ensure that the oldest bootstrap works
dra27
force-pushed
the
msvs-detect-reprised
branch
from
2445104 to
d56780b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts part of #17 (which I still want to come back to).
findwinsdkis an early version of what becamemsvs-detectwhich now lives at https://github.com/metastack/msvs-tools.The benefits of the switch are threefold: