updater: Update CMake to make builds more reproducible#13146
Open
RytoEX wants to merge 1 commit intoobsproject:masterfrom
Open
updater: Update CMake to make builds more reproducible#13146RytoEX wants to merge 1 commit intoobsproject:masterfrom
RytoEX wants to merge 1 commit intoobsproject:masterfrom
Conversation
Strip the PDB. Provide an alternate path for the PDB. We already use /PDBALTPATH for set_target_properties_obs, but this target understandably does not use that. Use an undocumented MSVC linker flag to not emit tool version info.
RytoEX
added
Enhancement
Member
Author
Tested an update from 32.0.2 to 32.0.4 and it worked fine. Tested an update from 32.0.4 to 32.1.0-rc1 and it also worked fine. |
derrod
reviewed
Feb 20, 2026
| $<$<CONFIG:DEBUG>:/NODEFAULTLIB:LIBCMT> | ||
| /PDBALTPATH:updater.pdb | ||
| /PDBSTRIPPED:updater.pdb | ||
| /EMITTOOLVERSIONINFO:NO |
Member
There was a problem hiding this comment.
This one should probably be set in the compiler options for the entire project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Strip the PDB. Provide an alternative path for the PDB.
We already use /PDBALTPATH for set_target_properties_obs, but this target understandably does not use that.
Use an undocumented MSVC linker flag to not emit tool version info.
Motivation and Context
Discovered while working on other changes to the updater. Don't want to have to do these steps manually.
How Has This Been Tested?
Tested the build locally and confirmed the link options made it into the project and applied. Will do an updater test run with this and #13137 later.
Types of changes
Checklist: