frontend: Fix setting the T-bar position through the API#13143
Open
djordje-mancic wants to merge 1 commit intoobsproject:masterfrom
Open
frontend: Fix setting the T-bar position through the API#13143djordje-mancic wants to merge 1 commit intoobsproject:masterfrom
djordje-mancic wants to merge 1 commit intoobsproject:masterfrom
Conversation
dc4fd1f to
f391056
Compare
Author
I'm not sure it's fair to call my PR a duplicate and then force-push very similar code to your repo afterwards, but I'm fine with any one's PR getting merged as long as it fixes this bug in OBS. |
Contributor
My bad. Just checked that the simplified one is similar to what you have done. Yeah, yours too look neat! Closing #13116 in favor of this. ✌️ |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
obs_frontend_set_tbar_positionfunction and makes it actually set the position (value) of the T-bar slider instead of invoking theTBarChangedmethod directly.Motivation and Context
This fix is required as, without it, it is impossible to perform T-bar transitions through the API.
This is because the
TBarReleasedmethod, which is responsible for finishing the transition from one scene to another, checks the T-bar position, which never gets set by this function.Fixing this function would make it possible to implement support for physical T-bars on video switcher boards through plugins.
Resolves issue 11372.
How Has This Been Tested?
I've tested this fix with a plugin that lets me control the T-bar position by moving a physical T-bar.
Types of changes
Checklist: