libobs-d3d11: Put d3d11 and d3d12 common functions together#12715
Closed
wanhongqing123 wants to merge 1 commit intoobsproject:masterfrom
Closed
libobs-d3d11: Put d3d11 and d3d12 common functions together#12715wanhongqing123 wants to merge 1 commit intoobsproject:masterfrom
wanhongqing123 wants to merge 1 commit intoobsproject:masterfrom
Conversation
3dee991 to
c361d72
Compare
c361d72 to
694a8e5
Compare
Member
|
While I think that it makes sense to share generic D3D code between a DirectX11 and DirectX12 renderer, I don't see much value in splitting those off without the new renderer in place. The change should be coupled with a PR for the new renderer and the shared functionality should probably be placed in the Until that new renderer is ready for production and reviewable, I don't see much benefit in merging it before that. |
Author
|
reopen when #12907 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Put d3d11 and d3d12 common functions together.
Motivation and Context
I am currently writing the implementation of D3D12. During this process, I found that there are many functions that are needed by both D3D11 and D3D12, so I summarized these functions together.
How Has This Been Tested?
I have tested in my compute.
Types of changes
Checklist: