Skip to content

Comments

libobs: Code cleanup put swapchain create and swapchain destroy together for easier reading.#11149

Closed
wanhongqing123 wants to merge 1 commit intoobsproject:masterfrom
wanhongqing123:master-code-clean
Closed

libobs: Code cleanup put swapchain create and swapchain destroy together for easier reading.#11149
wanhongqing123 wants to merge 1 commit intoobsproject:masterfrom
wanhongqing123:master-code-clean

Conversation

@wanhongqing123
Copy link

@wanhongqing123 wanhongqing123 commented Aug 18, 2024

Description

I want to put swapchain create and swapchain destroy together for easier reading

Motivation and Context

I want to put swapchain create and swapchain destroy together for easier reading

How Has This Been Tested?

I have tested in my windows 10 and ubuntu 24

Types of changes

code clean

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Fenrirthviti
Copy link
Member

Please properly explain the reason behind these changes. Additionally, this does not meet our commit guidelines, and will need to be more explicit.

@wanhongqing123
Copy link
Author

Please properly explain the reason behind these changes. Additionally, this does not meet our commit guidelines, and will need to be more explicit.

I want to put swapchain create and swapchain destroy together for easier reading

@wanhongqing123 wanhongqing123 changed the title libobs: code clean libobs: code clean, put swapchain create and swapchain destroy together for easier reading. Aug 18, 2024
@wanhongqing123 wanhongqing123 changed the title libobs: code clean, put swapchain create and swapchain destroy together for easier reading. libobs: code clean put swapchain create and swapchain destroy together for easier reading. Aug 18, 2024
@wanhongqing123 wanhongqing123 changed the title libobs: code clean put swapchain create and swapchain destroy together for easier reading. libobs: Code clean put swapchain create and swapchain destroy together for easier reading. Aug 18, 2024
@wanhongqing123 wanhongqing123 changed the title libobs: Code clean put swapchain create and swapchain destroy together for easier reading. libobs: Code cleanup put swapchain create and swapchain destroy together for easier reading. Aug 18, 2024
@RytoEX RytoEX requested review from Lain-B and jpark37 August 20, 2024 22:04
@jpark37 jpark37 removed their request for review August 21, 2024 05:09
@WizardCM WizardCM added the Code Cleanup Non-breaking change which makes code smaller or more readable label Aug 24, 2024
@wanhongqing123
Copy link
Author

reopen when #12907 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Cleanup Non-breaking change which makes code smaller or more readable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants