feat: add k8s settings update notification in deployment status #5396

ryu-man · 2026-01-01T00:06:08Z

Addresses #4997

implement server-side logic
show a yellow update icon to indicate update in k8s settings
fix issue where server is re-deployed when navigating to /admin/mcp-servers/c/[x]/instance/[y]/details route

…faces

…ngs drift detection

ryu-man · 2026-01-01T00:46:38Z

@ivyjeong13 I am not sure if it is better to add an "Update k8s setting" item to the dots menu; however, I lean toward that. What do you think?

thedadams

You would also need to run go generate to fix the Go listing.

thedadams · 2026-01-05T11:55:28Z

pkg/api/handlers/mcp.go

+		if err := req.Storage.Status().Update(req.Context(), &server); err != nil {
+			return fmt.Errorf("failed to update server status: %w", err)
+		}


Typically, we wouldn't want to do this in the API. Instead, let the controller update the field.

I think it's fine if you want to ensure the value is true when returning from the API, but better to let the controller update the database.

thedadams · 2026-01-05T12:03:50Z

pkg/controller/handlers/k8ssettings/k8ssettings.go

This file should be deleted.

The way our controller framework works, the two controllers you wrote (one for servers and one for catalog entries) will do the correct thing when the k8s settings change.

thedadams · 2026-01-05T12:06:16Z

pkg/controller/handlers/mcpservercatalogentry/mcpservercatalogentry.go

 }

+// DetectK8sSettingsDrift detects when servers created from this catalog entry need redeployment with new K8s settings
+func DetectK8sSettingsDrift(req router.Request, _ router.Response) error {


This should be deleted.

The way our controller framework works, the controller you added for MCP servers will do the right thing.

thedadams · 2026-01-05T12:09:36Z

pkg/mcp/details.go

+func isServerNotRunningError(err error) bool {
+	if err == nil {
+		return false
+	}
+	return strings.Contains(err.Error(), "is not running")
+}


It's better to create a type for this and use errors.As or errors.Is then match on the string.

Please let me know if the change I made is what you mean

thedadams · 2026-01-05T12:13:29Z

pkg/storage/apis/obot.obot.ai/v1/mcpservercatalogentry.go

 	// NeedsUpdate indicates whether this composite catalog entry's component snapshots have drifted from their sources.
 	NeedsUpdate bool `json:"needsUpdate,omitempty"`
+	// NeedsK8sUpdate indicates whether servers created from this catalog entry need redeployment with new K8s settings
+	NeedsK8sUpdate bool `json:"needsK8sUpdate,omitempty"`


Based on what I saw in the implementation, this can be removed. It seems like it was used to track when all servers deployed from this entry should be upgraded, but that is already handled by the MCP server controllers.

thedadams · 2026-01-05T12:13:50Z

apiclient/types/mcpserver.go

 	PowerUserWorkspaceID      string                        `json:"powerUserWorkspaceID,omitempty"`
 	PowerUserID               string                        `json:"powerUserID,omitempty"`
 	NeedsUpdate               bool                          `json:"needsUpdate,omitempty"`
+	NeedsK8sUpdate            bool                          `json:"needsK8sUpdate,omitempty"`


I believe this can also be removed.

If I delete this I do get the following error in mcp.go line 159

unknown field NeedsK8sUpdate in struct literal of type "github.com/obot-platform/obot/apiclient/types".MCPServerCatalogEntry

We don't need to track this for catalog entries. There are no deployments for catalog entries, so this field and all of its references should be removed.

cjellick · 2026-01-06T17:04:13Z

can I get a quick loom of this working end to end, including updating the k8s settings for the server and seeing it successfully redeploy

ryu-man · 2026-01-06T17:38:48Z

Yep, working on that

ryu-man · 2026-01-06T17:55:11Z

@cjellick https://www.loom.com/share/5001ecf38d654f878498d488a0b01f69

cjellick · 2026-01-06T18:31:24Z

@ryu-man - looking good. a couple things:

in the Status dropdown filter, can we add entries for the two different types of updates available? id like to be able to filter to servers that JUST need a k8s update or JUST need a catalog update
Somewhat related, I want to make sure we can bulk update by checking more that one row and clicking a button.

Then end goal here is if i have a ton of seves and change the default k8s resources, i can easily update them all.

ryu-man · 2026-01-06T19:21:14Z

@cjellick Working on that

ryu-man · 2026-01-06T23:30:28Z

@ryu-man - looking good. a couple things:

in the Status dropdown filter, can we add entries for the two different types of updates available? id like to be able to filter to servers that JUST need a k8s update or JUST need a catalog update

Somewhat related, I want to make sure we can bulk update by checking more that one row and clicking a button.

Then end goal here is if i have a ton of seves and change the default k8s resources, i can easily update them all.

@cjellick loom for request changes.

https://www.loom.com/share/c5d286dd82fc4f8693fd2530fa45e941

ryu-man · 2026-01-06T23:36:14Z

@cjellick Currently, if a user selects only "Kubernetes Upgrade Available," those servers with both server and Kubernetes will not be included, because currently the table filters allow matches only against a single value. if this PR can wait a little bit longer, I can work on a solution; otherwise, this can tracked in a separate PR if necessary

cjellick · 2026-01-06T23:50:22Z

@ryu-man this pr can wait for you to find a solution.

Regarding your loom, here's some feedback:

Instead of saying "Kubernetes Upgrade Available", let's say "Scheduling Update Available"
Instead of saying "Upgrade Available", let's New Server Config Available"
And then make the action buttons match that, so like "Update Scheduling Configuration" and "Update Server"

Let me see a loom for that bc I'm not 100% sure itll look good.

Also, since we now have explicit text for the status, i think we can just drop the upgrade icons...they were there so that that column could do "double duty" of health status and upgrade status. so now I think we need two separate columns:

Health
Update Status

- allow multi-values filteration - remove updates icons - use colors on rows to indicate updates

ryu-man · 2026-01-07T17:07:40Z

@cjellick loom for the above requested changes + new status filteration approach

https://www.loom.com/share/884386f2ec324728a249792de4b1ed12

ryu-man added 5 commits December 31, 2025 19:04

feat: add Kubernetes upgrade notification to deployment status

2572a8a

feat: add needsK8sUpdate flag to MCPCatalogEntry and ProjectMCP inter…

3dd2afa

…faces

feat: add NeedsK8sUpdate flag and related functionality for K8s setti…

33e56ee

…ngs drift detection

fix: remove unnecessary blank lines in UpdateMCPServerStatus function

4326639

remove redundant code

ae49a25

ryu-man marked this pull request as ready for review January 1, 2026 00:43

ryu-man requested review from g-linville, ivyjeong13, njhale and thedadams January 1, 2026 00:43

thedadams requested changes Jan 5, 2026

View reviewed changes

ryu-man added 2 commits January 5, 2026 22:26

address feedbacks - remove unecessary code

607b266

run go generate

a5741f5

ryu-man requested a review from thedadams January 6, 2026 17:54

ryu-man added 3 commits January 6, 2026 14:23

cleanup code

e8a54a3

feat: add Kubernetes settings update functionality in DeploymentsView

6ce01ce

feat: enhance deployment status updates for Kubernetes compatibility

eb40233

ryu-man added 4 commits January 7, 2026 11:48

improve status filteration proccess

1b0dafb

- allow multi-values filteration - remove updates icons - use colors on rows to indicate updates

fix: update row border styling for improved visual consistency

a50fe90

fix: adjust table header and row styling for improved layout consistency

6024e21

fix: update button label

fc357d7

feat: add k8s settings update notification in deployment status #5396

Are you sure you want to change the base?

feat: add k8s settings update notification in deployment status #5396

Uh oh!

Conversation

ryu-man commented Jan 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ryu-man commented Jan 1, 2026

Uh oh!

thedadams left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjellick commented Jan 6, 2026

Uh oh!

ryu-man commented Jan 6, 2026

Uh oh!

ryu-man commented Jan 6, 2026

Uh oh!

cjellick commented Jan 6, 2026

Uh oh!

ryu-man commented Jan 6, 2026

Uh oh!

ryu-man commented Jan 6, 2026

Uh oh!

ryu-man commented Jan 6, 2026

Uh oh!

cjellick commented Jan 6, 2026

Uh oh!

ryu-man commented Jan 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ryu-man commented Jan 1, 2026 •

edited

Loading