Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As promised here is a PR with all the changes needed to support Flysystem 3.
We're currently using this in production and it works well.
I haven't touched any of the documentation yet so this is most definitely out-of-date.
We are currently running this with Redis as persistent cache:
The RedisCacheFactory looks like this:
Here you can see we use the ChainAdapter to also do in-memory caching for even more speeeeeed.
Let me know what you think.
I also noticed another branch were similar changes were done for Flysystem 3 support, I probably should have opened a draft PR to make our efforts more visible to prevent doing twice the work. We had a project to launch so that's what I focused on :)