Open
Conversation
✅ Deploy Preview for oasisprotocol-oasis-sdk canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2425 +/- ##
==========================================
- Coverage 48.55% 48.54% -0.01%
==========================================
Files 224 224
Lines 16079 16079
==========================================
- Hits 7807 7806 -1
- Misses 8212 8213 +1
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
matevz
reviewed
Jan 16, 2026
Member
matevz
left a comment
There was a problem hiding this comment.
Prerequisites also do not seem an appropriate place, because it focuses on a developer setting up development environment on their machine.
Perhaps add it to https://docs.oasis.io/build/rofl/workflow/build under a new "Reproducible builds" section at the end and mention that developers can use the Oasis CLI github action as part of their CI/CD of the app.
20a63c1 to
0cdef5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documenting GitHub Action, not sure how to reference it inside the ROFL Build section, since it doesnt even talk about installing the CLI, so I just mentioned it in the prerequisits. @matevz
Resolves oasisprotocol/docs#1638