Skip to content

Conversation

@Maximvdw
Copy link

@Maximvdw Maximvdw commented Feb 5, 2025

null check implementation

Copy link
Collaborator

@woutslabbinck woutslabbinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does indeed make sense that if there are no link headers to Description Resources (.meta resources), the method findService returns null gracefully.

I think for the code to make perfect sense, discoverStorageDescription its type must also be changed to Promise<string | null> to indicate that not every resource has a Description Resource.

Other than that, it looks good to me and can be merged given that change.
After the merge, @jaxoncreed will have to bump/publish the package on npm as he is the only person with that permission.

@Maximvdw
Copy link
Author

I will make the requested changes. Ill keep you updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants