Conversation
|
Following this as well. Is this repository maintained? |
isaacwhite
left a comment
There was a problem hiding this comment.
Thanks so much for taking a pass at #156, @midorikocak! And thanks for your patience while we got around to reviewing this PR.
Adding an environment variable to trigger the public site behavior seems like a great way to opt-in to unauthenticating most of the site.
Since Library pages are rendered dynamically (except for caching of doc contents), would you be interested in making the edit buttons conditional based on the login status?
In that case, I wonder if we could trigger the login flow only on a predetermined url (like /login) so that administrators could view the site edit buttons.
That approach would also lend itself to the expansion of authenticated-only pages (like an audit log of some kind), but could come in a separate PR if you'd rather keep this PR more narrowly scoped.
Let me know how you'd like to proceed, and thanks for contributing to Library!
Description of Change
Adds env option PUBLIC_SITE to allow non-authenticated users to view. Hides google docs links. It requires a PUBLIC_SITE=true variable to be added to the .env file
Related Issue
#156
Motivation and Context
Checklist
npm run lintand updated code style accordinglynpm run testpassesNeed some feedback on tests and documentation changes.