Skip to content

Added functions for Deltas#3

Open
harrysinghtiwana wants to merge 12 commits intonylas:masterfrom
lawcus:master
Open

Added functions for Deltas#3
harrysinghtiwana wants to merge 12 commits intonylas:masterfrom
lawcus:master

Conversation

@harrysinghtiwana
Copy link

Added function getDeltas, getDeltaCursor and createAuthHeader

Added function getDeltas, getDeltaCursor and createAuthHeader
@khamidou
Copy link
Contributor

Hi @lawcus. Thanks for the pull request!

This pull request looks good to me; I only have three concerns:

  1. It would be nice if getDeltas returned a list of NylasAPIObjects instead of plain JSON arrays.
  2. Could you update README.md too?
  3. Are you using an IDE? I see you have changed indent style for all the braces in the file. Please revert this.

Also, to merge this I'd need you to sign our Contributor License Agreement. It's similar to the one used by meteor and nodejs.

regards,

Karim

@harrysinghtiwana
Copy link
Author

We will update it to NylasObject as well as READMe.md in next update. Yes, we are using PHPStorm, removed the braces. Also, we have signed Agreement. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants