Chapter 4: Broken authentication - code #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nxvl
changed the base branch from
3.2-weak-password-storage/test
to
3.2-weak-password-storage/fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chapter 4: Broken Authentication
Requirement
Now that we have users in the system, we need to allow them to login.
Development
We add a simple form to allow users to login, check for user and password to be correct and add a simple session. If something goes wrong, we drop some error messages.
Vulnerability
Since we are very transparent and explicit in our error messages, an attacker can take advantage of them to enumerate users on our system. This could be done to reduce time of a brute force or credential stuffing attack.