Skip to content

Conversation

@dakshshahani
Copy link
Collaborator

Reason

Be able to group by meal counts (Day1Breakfast etc.) in admin query

Explanation

Updated const groupable in the QueryFilters function in query-filters.tsx to allowing grouping of columns by numeric data type as well.

@martincai8
Copy link
Contributor

lfg

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Visit the preview URL for this PR (updated for commit 271e0ff):

https://dev-nwplus-admin--pr77-daksh-group-by-meals-hkl5gmch.web.app

(expires Wed, 17 Dec 2025 22:33:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c290bf9e2fac0401389f751f415cce4267517b51

@tdanielles
Copy link
Contributor

tysm for taking one of our tickets!! generally looks good to me, one thing is would you also be able to add support for the snack columns (if exists for a particular hackathon)? tyyyyy 🚀

@daniel-panhead
Copy link
Contributor

dev next year????

@paultibe
Copy link

paultibe commented Dec 4, 2025

holy W

Copy link
Contributor

@ErpingS ErpingS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dakshshahani do you mind taking a look at the comment trisha left? We recently added snack as another value count for HC 2025.

Can take a look at this PR for more background on the snack (ctrl-f for "snack"):
https://github.com/nwplus/qr-check-in/commit/9d7792abe500f4b3cfcf17e454b6811e49c8f4bb#diff-8e4e4cd0d75f77ab0c9a8dbb4d0c7d65f8737a2a75c33a07e688097c852b43e5R5

@ErpingS
Copy link
Contributor

ErpingS commented Dec 7, 2025

Added in snacks value and tested (see screenshots)

Screenshot 2025-12-07 at 2 31 46 PM Screenshot 2025-12-07 at 2 31 56 PM Screenshot 2025-12-07 at 2 32 13 PM

@ErpingS ErpingS merged commit e11cc99 into dev Dec 9, 2025
5 checks passed
@ErpingS ErpingS deleted the daksh/group_by_meals_fix branch December 9, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants