fix(lsp): use regex for pub workspace detection instead of YAML parsing#516
Merged
sidlatau merged 1 commit intonvim-flutter:mainfrom Jan 14, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes workspace root detection in the LSP by replacing full YAML parsing with simple regex-based pattern matching for detecting pub workspace members and roots. The YAML parser was failing silently on complex pubspec files (e.g., those containing generate:dart syntax), causing workspace root detection to fail and multiple LSP servers to spawn.
Changes:
- Replaced YAML parsing with regex pattern matching for workspace detection, matching VS Code Dart extension behavior
- Fixed iterate_parents skipping the immediate parent directory during workspace root search
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
this is the pubspec.yaml section that made the yaml parser fail: // melos configure
melos:
// ...
generate:
steps:
- generate:dart
- generate:flutter
description: Build all generated files for Dart & Flutter packages. |
sidlatau
approved these changes
Jan 14, 2026
Collaborator
|
Thanks, @khensunny! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace full YAML parsing with simple pattern matching for detecting
pub workspace members and roots. The YAML parser fails silently on
complex pubspec files (e.g., containing
generate:dartsyntax),causing workspace root detection to fail and multiple LSP servers
to spawn.
Also fix iterate_parents skipping the immediate parent directory
when searching for workspace root.
Patterns match VS Code Dart extension behavior.
Note
AI was used in the creation of this work
Closes: #515