Receivers are non-deterministic #175
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafiosca
added
bug
Member
|
This is a great find and I appreciate the work and PR. I have not been actively maintaining this library for a long time, and unfortunately there is no current maintainer. Additionally, I am in the process of winding down Nuclear Pasta and have been considering what I should do about this library. I will take a look and see if I can merge this and publish a new version, but I want to set expectations that it might take me a while to get to it. |
LunatiqueCoder
requested changes
Oct 12, 2024
Member
LunatiqueCoder
left a comment
LunatiqueCoder
left a comment
There was a problem hiding this comment.
I don't think the build folder should be commited?
Author
|
@LunatiqueCoder sorry about that, I'll fix it when the rest of the MR gets reviewed. |
Member
|
do you have a reproduction example to test the changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findMonitorsAndReceiverInRegistry will look through the registry viewIds and return the last receiver which matches. the problem here is that this assumes that the order of receiver ids in the registry viewIds is bottom to top. this is not always the case when you have various receivers re-rendering for various reasons. this resulted in a non-deterministic receiver being called on drop instead of the top most one. in order to fix this, I added a resolution algorithm in the case that multiple receivers overlap the target point. the resolution algorithm solves the issue first by looking through the parent tree and removing all parents. while I believe this should be enough, for safety, I added an additional fallback measure which chooses the receiver with the smallest area as generally things on top should be smaller than things on bottom.