Draft
Conversation
Contributor
|
@ionut Do you need this PR to be integrated into main? If we integrated into main this function needs to be included as an API into the crypto.h include. |
Contributor
Author
Don't include it in the main. I think we got it working with the serial numbers, however it may be needed in the future. We could probably delete the PR for now and reopen later if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the LDevIDs and IDevIDs to the log file /var/log/brski-registrar.log to make it easier for @AshleySetter and @james to integrate it into their implementation.