Add accessibility features to the Rig #300
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in an issue to @thomaswilburn, this was my framework for accessibility:
Follow this guide and this guide, as well as the FT and Vox guides.
-Add HTML5 semantic markup to all child pages
-Add title/desc to all SVGs
-Add ARIA roles and alt titles to chart elements
-Add ARIA information to tables
-Add title to graphics iframe
In some cases, accessibility is aspirational and not supported yet by current browsers. Still, having these improvements in place for when browsers have better SVG accessibility support seemed worthwhile.
I don't have your lint file so the spacing is funny.