fix(ui): improve design of buttons/links with icons#1542
Draft
NeeshSamsi wants to merge 4 commits intonpmx-dev:mainfrom
Draft
fix(ui): improve design of buttons/links with icons#1542NeeshSamsi wants to merge 4 commits intonpmx-dev:mainfrom
NeeshSamsi wants to merge 4 commits intonpmx-dev:mainfrom
Conversation
Detect icon-only buttons with useSlot
sr-only spans made slots.default truthy, breaking auto-detection. aria-label is an equivalent accessible alternative that lets the slot be empty.
icon-only for mobile only breaks auto-detection. Manually override padding on mobile.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Author
|
All the errors scared me for a second but it seems like it's an issue with a package install? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1255
When detecting an icon-only button, I am detecting an empty slot. This was not working with the current
sr-onlyspans. I replaced them witharia-label. As far as I know, this shouldn't be a problem but please let me know if that was overstepping on the scope of this change.This is my first contribution to a major opensource project. Please let me know if I made any mistakes so I can figure it out.