Skip to content

added proper typing for icon class names #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yusra89hash wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

added proper typing for icon class names #1538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/components/Button/Base.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
<script setup lang="ts">
type StartIcon =
| `i-carbon:${string}`
| `i-lucide:${string}`
| `i-simple-icons:${string}`
| `i-svg-spinners:${string}`
| `i-custom:${string}`

const props = withDefaults(
defineProps<{
disabled?: boolean
Expand All @@ -8,7 +15,7 @@ const props = withDefaults(
ariaKeyshortcuts?: string
block?: boolean

classicon?: string
classicon?: StartIcon
}>(),
{
type: 'button',
Expand Down
3 changes: 2 additions & 1 deletion app/pages/package/[[org]]/[name].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,9 @@ const { copied: copiedPkgName, copy: copyPkgName } = useClipboard({
})

//copy version name
//orginally only copied name and not version number
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Typo and stale comment should be removed.

"orginally" is a misspelling of "originally". More broadly, the comment describes the old (broken) behaviour rather than the current intent — it reads as a leftover PR note and adds noise as permanent inline documentation.

🔧 Proposed fix 
-//orginally only copied name and not version number
 const { copied: copiedVersion, copy: copyVersion } = useClipboard({
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
//orginally only copied name and not version number
const { copied: copiedVersion, copy: copyVersion } = useClipboard({

const { copied: copiedVersion, copy: copyVersion } = useClipboard({
source: resolvedVersion.value ?? '',
source: () => resolvedVersion.value ?? '',
copiedDuring: 2000,
})

Expand Down
Loading