Skip to content

fix: prevent crash when expanding directories.bin without filesystem path #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owlstronaut merged 2 commits into from
Nov 18, 2025
+15 −1
Merged

fix: prevent crash when expanding directories.bin without filesystem path #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ea6c76
fix: prevent crash when expanding directories.bin without filesystem …
Nov 14, 2025
b544e4e
add test for directories.bin without filesystem path
Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/normalize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ async function asyncSteps (pkg, { steps, root, changes }) {
}

// expand "directories.bin"
if (steps.includes('binDir') && data.directories?.bin && !data.bin) {
if (steps.includes('binDir') && data.directories?.bin && !data.bin && pkg.path) {
const binPath = secureAndUnixifyPath(data.directories.bin)
const bins = await lazyLoadGlob()('**', { cwd: path.resolve(pkg.path, binPath) })
data.bin = bins.reduce((acc, binFile) => {
Expand Down
14 changes: 14 additions & 0 deletions test/normalize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,20 @@ for (const [name, testNormalize] of Object.entries(testMethods)) {
t.strictSame(content.bin, { echo: 'bin/echo' })
})

t.test('directories.bin without filesystem path', async t => {
const p = new Pkg()
p.fromContent({
name: 'registry-test',
version: '1.0.0',
directories: {
bin: './bin',
},
})
await p.normalize({ steps: Pkg.normalizeSteps })
t.notOk(p.content.bin, 'bin should not be expanded without filesystem path')
t.ok(p.content.directories.bin, 'directories.bin should be preserved')
})

t.test('dedupe optional deps out of regular deps', async t => {
t.test('choose optional deps in conflict, removing empty dependencies', async t => {
const { content } = await testNormalize(t, ({
Expand Down
Loading