security: sanitize tokens from error messages#3
Open
domid wants to merge 1 commit intonovincode:mainfrom
Open
Conversation
Add sanitizeTokens() helper to prevent credential leaks in error output. Redacts: - Cloudflare API tokens (cf_XXX pattern) - CLOUDFLARE_API_TOKEN env var assignments - Bearer tokens in auth headers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds token sanitization to prevent credential leaks in error output.
Problem
When Wrangler fails, its stderr output could potentially contain the API token (e.g., in debug messages or certain error conditions). This token would then be displayed to the user in the console.
Solution
Added a
sanitizeTokens()helper function that redacts sensitive tokens before any error message is logged or returned:cf_XXX...→[REDACTED]CLOUDFLARE_API_TOKEN=xxx→CLOUDFLARE_API_TOKEN=[REDACTED]Bearer xxx→Bearer [REDACTED]Changes
src/utils/shell.ts: AddedsanitizeTokens()function and applied it to error message handling inrunWranglerCommand()Testing