implements 'scan' command #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements 'scan' command which receives three paramaters
- table: table name
- options: Erlang proplist to specify scan options.
- ref: Erlang reference to distinguish rows from multiple scans
API returns `ok` after starting scan asyncronously. It returns each rows
with {Ref, row, [ColumnList]} messages for each cells. If there is an
error occures during scan, it sends {Ref, error, Name, Msg} and
terminates scan. If all rows are successfully returned, it sends {Ref,
done} message.
refactor code: use GenServerCallback to reduce duplicated codes add ops: compare_and_set, increment
add rebar project which enables running app without elixer dependencies
Add more APIs: ensure_table_{,family}_exists, flush, prefetch_meta
Ensure HBaseClient connects to cluster on hbase_server:init/1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements 'scan' command which receives three paramaters
API returns
okafter starting scan asyncronously. It returns each rowswith
{Ref, row, [ColumnList]}messages for each cells. If there is anerror occures during scan, it sends
{Ref, error, Name, Msg}andterminates scan. If all rows are successfully returned, it sends
{Ref, done}message.note: This PR implements proof-of-concept mechanism of
scancommand. Any comments/reviews/feedbacks are welcome. Here's some ideas{Ref, {error, Name, Msg}}might be better than{Ref, error, Name, Msg}because we can use single error handling function for bothscanandget. Same for other messages.{Ref, row, [Rows]}might be better