refactor(docs-infra): remove expand button when there is no hidden lines #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dans le titre (et un peu partout où on utilise cette formulation) :
Est-ce qu'on ne reformulerai pas en
? |
ColinJolivet
changed the title
tverhoken
reviewed
Oct 22, 2024
adev/shared-docs/components/viewers/example-viewer/example-viewer.component.spec.ts
Outdated
Show resolved
Hide resolved
adev/shared-docs/components/viewers/example-viewer/example-viewer.component.ts
Outdated
Show resolved
Hide resolved
adev/shared-docs/components/viewers/docs-viewer/docs-viewer.component.spec.ts
Outdated
Show resolved
Hide resolved
ColinJolivet
force-pushed
the
refactor/dont-show-expand-button-when-there-is-no-hidden-line
branch
3 times, most recently
from
cfbc59e to
2f243f9
Compare
ColinJolivet
force-pushed
the
refactor/dont-show-expand-button-when-there-is-no-hidden-line
branch
from
2f243f9 to
499c976
Compare
ColinJolivet
force-pushed
the
refactor/dont-show-expand-button-when-there-is-no-hidden-line
branch
from
499c976 to
8d5cf9b
Compare
tverhoken
reviewed
Dec 5, 2024
adev/shared-docs/components/viewers/example-viewer/example-viewer.component.spec.ts
Outdated
Show resolved
Hide resolved
… is no hidden lines Remove the expand button of an example viewer if there is no hidden lines in it, in order not to confuse people
ColinJolivet
force-pushed
the
refactor/dont-show-expand-button-when-there-is-no-hidden-line
branch
from
8d5cf9b to
5e7dffb
Compare
Collaborator
Author
|
PR approved in intern |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for internal review
Remove the expand button of an example viewer when there is no hidden lines in it, in order not to confuse people
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: angular#53279
What is the new behavior?
No more expand button when there is no hidden lines in the example viewer
Does this PR introduce a breaking change?
Other information
Initially there was a test on the operation of the expand button in the doc-viewer.componenent.spec.ts, but I moved it to the example-viewer.component.spec.ts as it seemed more appropriate.