fix: extensions stuff and safari import#303
Merged
judekim0507 merged 2 commits intonook-browser:devfrom Feb 18, 2026
Merged
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughAdds Safari Extension discovery/installation UI and workflows, introduces WebKit MAIN-world bridge for externally_connectable messaging, improves extension manager diagnostics and native messaging buffering, ensures per-tab userContentController isolation, and adds macOS horizontal scroll-driven page navigation. Changes
Sequence DiagramssequenceDiagram
participant User as User
participant UI as SettingsView
participant Mgr as ExtensionManager
participant Sys as System/FS
User->>UI: Tap "Scan for Safari Extensions"
UI->>Mgr: scanForSafariExtensions()
Mgr->>Sys: discoverSafariExtensions()
Sys-->>Mgr: [SafariExtensionInfo...]
Mgr-->>UI: Return results (main thread)
UI->>UI: showSafariSection = true / render list
User->>UI: Tap "Install" on extension
UI->>Mgr: installSafariExtension(info)
Mgr->>Mgr: resolve resources, patch manifest, setup bridge
Mgr->>Sys: copy/install to temp/location
Sys-->>Mgr: success / error
Mgr-->>UI: completion handler (update UI / show alert)
sequenceDiagram
participant User as User/ScrollWheel
participant Coord as Page Coordinator
participant NSPg as NSPageController
participant Views as Hosted Views
User->>Coord: scrollWheel(event)
alt horizontal swipe detected
Coord->>Coord: compute direction & trigger navigateByDirection()
Coord->>NSPg: go(to: targetIndex)
NSPg->>Views: animate transition (0.18s)
Views-->>NSPg: transition complete
NSPg-->>Coord: selection updated
Coord->>Parent: update selection binding
else vertical/other
Coord-->>Views: forward event (default handling)
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP for oauth
Summary by CodeRabbit
Release Notes
New Features
Improvements