feat: command palette close with esc and site search#300
feat: command palette close with esc and site search#300judekim0507 merged 5 commits intonook-browser:devfrom
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis PR introduces site-scoped search functionality to the command palette, enabling users to search within specific websites directly from the search interface. It adds a new Changes
Sequence DiagramsequenceDiagram
participant User
participant CommandPalette as Command Palette
participant SearchManager as Search Manager
participant SiteSearch as Site Search
participant Navigator as Navigator
User->>CommandPalette: Type search query
CommandPalette->>SearchManager: Get suggestions
SearchManager-->>CommandPalette: Return suggestions
alt Tab key pressed
User->>CommandPalette: Press Tab
CommandPalette->>SiteSearch: Find matching site
SiteSearch-->>CommandPalette: Return SiteSearchEntry
CommandPalette->>CommandPalette: Set activeSiteSearch
CommandPalette-->>User: Show site-scoped suggestions
end
alt Return key pressed
User->>CommandPalette: Press Return
CommandPalette->>SiteSearch: Generate search URL
SiteSearch-->>CommandPalette: Return site-specific URL
CommandPalette->>Navigator: Navigate to URL
Navigator-->>User: Load search results
CommandPalette->>CommandPalette: Reset activeSiteSearch
end
alt Escape key pressed
User->>CommandPalette: Press Escape
CommandPalette->>CommandPalette: Clear activeSiteSearch
CommandPalette-->>User: Return to normal search
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~55 minutes Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Summary by CodeRabbit