feat: make linked-versions pull request title configurable#4
Closed
feat: make linked-versions pull request title configurable#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Summary
This PR makes the
linked-versionsplugin's pull request title configurable via thegroup-pull-request-title-patternoption. Previously, the title was hardcoded tochore${scope}: release ${groupName} ${version}. Now users can customize it while maintaining backward compatibility.Changes
groupPullRequestTitlePatternoption to plugin factory and manifestlinked-versionsplugin to use configured pattern, defaulting tochore${scope}: release ${groupName} librariesfor backward compatibility${component}placeholder in the pattern is replaced with the plugin'sgroupNamecustomizing.mdandmanifest-releaser.mdHuman Review Checklist
${version})${component}placeholder replacement works correctly inlinked-versions.ts:183-187${version}tolibrariesis intentionalThis is for our internal update here
created an upstream PR too
googleapis#2617
Fixes #<issue_number_goes_here> 🦕