refactor: move take() impl to SeriesBufferGuard#145
Open
KevinWMatthews wants to merge 1 commit intonominal-io:mainfrom
Open
refactor: move take() impl to SeriesBufferGuard#145KevinWMatthews wants to merge 1 commit intonominal-io:mainfrom
KevinWMatthews wants to merge 1 commit intonominal-io:mainfrom
Conversation
This was referenced Dec 15, 2025
KevinWMatthews
commented
Dec 15, 2025
Comment on lines
+642
to
+644
| let result_count = self | ||
| .count | ||
| .fetch_update(Ordering::Release, Ordering::Acquire, |_| Some(0)) |
Contributor
Author
There was a problem hiding this comment.
Write access to the count now must occur through SeriesBufferGuard, as SeriesBuffer is not in scope.
Comment on lines
694
to
696
| UNIX_EPOCH.elapsed().unwrap().as_nanos() as u64, | ||
| Ordering::Release, | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
Unlike count, flush_time is not considered in this PR.
The mechanics of how these two values are accessed are a little bit different, and I haven't considered flush_time deeply.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the bulk of the implementation of
take()fromSeriesBuffertoSeriesBufferGuard. The intent is to consolidate the responsibility for updating the point count in theSeriesBufferGuard.Specifically, this ensures that
take()can only updatecountthroughSeriesBufferGuard.