refactor: add SeriesBufferInner type#144
Open
KevinWMatthews wants to merge 3 commits intonominal-io:mainfrom
Open
refactor: add SeriesBufferInner type#144KevinWMatthews wants to merge 3 commits intonominal-io:mainfrom
KevinWMatthews wants to merge 3 commits intonominal-io:mainfrom
Conversation
Move two fields of SeriesBuffer into a new type, SeriesBufferInner. This inner type provides/controls access to: - the points buffer (write, mutex-guarded) - the count (read-only, atomic)
This was referenced Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves two fields of
SeriesBufferinto a new type,SeriesBufferInner, the moves this type to a moduleinner. This inner type provides/controls access to:The
innermodule restricts direct access to these struct members, requiring access throughSeriesBufferInner's API.The intent is for:
For the motivation behind this PR, see #139.