Convert documentation test from Spock to JUnit 5 #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
This new link checker doesn't give contexts but that should be handled by the assertion instead of the crawler framework. It now create a different JUnit test for each URL to check. Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
We didn't convert all test cases as some are pending analysis to be potentially removed. Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the major cleanup and upgrades we need to improve testing. We started with the documentation tests to showcase performance improvement and thus develop more samples. The documentation tests are also more ad-hoc, so it will stress the approach we take.