Skip to content

Prepare discovery avoidance work #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lacasseio wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Prepare discovery avoidance work #635

lacasseio wants to merge 44 commits into from

Conversation

@lacasseio
Copy link
Member

@lacasseio lacasseio commented May 20, 2022

No description provided.

@lacasseio lacasseio self-assigned this May 20, 2022
@lacasseio lacasseio force-pushed the lacasseio/prepare-discovery-avoidance branch from 4830236 to 9ec23b7 Compare June 15, 2022 14:18
lacasseio added 24 commits June 22, 2022 10:40
@lacasseio
Move default parent component creation to standalone rule
390153c 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Does not create display name component by default
bdbb9d0 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Extract default element name component to standalone rule
5f531d5 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Centralize entity creation and default components
708b403 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Centralize default components
eb57781 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Remove dependency on state change
d60a842 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Split rules with regards to concerns
f9d0717 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Remove created state
331985a 
The created state does not have any meaning anymore.

Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Returns null when no states
86c309f 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Remove initialized state
35a5f83 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Remove unused stateOf predicate factory
37464a3 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Remove unused predicate factory for projection
47696a7 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Remove withPath predicate factory
c7a1b23 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Ensure correct compileTasks property owner
5d37191 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Uses model tags instead of projection type for naming scheme
4da89e8 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Add component for ComponentSources property
97ce6a0 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Ensure correct owner for some entities
644c779 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Allow custom component elements discovery logic
0ed2b1e 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Add component for component variants property
2fb1f54 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Introduce development variant property component
2fc7590 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Move projection registration for JNI library variant to registration …
e74168e 
…factory

Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Introduce JVM bucket component for entity linking
f125e51 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Introduce shared library component for entity linking
ee83110 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Introduce compile tasks property component for entity linking
d910c98 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
lacasseio added 20 commits June 22, 2022 10:40
@lacasseio
Defer extendsFrom on Java plugin configuration to ensure discovery
b44ecf6 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Centralize baseName configuration
3a0db09 
If onwers has baseName, use their value, else use elementName.

Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Move developmentVariant configuration to standalone rule
7555db4 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Use ModelAction configuration
abdac65 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Allow auto-discovery per-tagged entities
0301b65 
This is not the exact solution we want but in term of full discovery
it's ok. We will want to move toward an incremental discovery when we
support `named` API.

Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Switch to a reactive lookup result
a9e298b 
Instead of computing the lookup result eagerly, we will allow processing
additional entities as they become available.

Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Try to generate property extension types
5001196 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Introduce component for dependencies property
b92777e 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Add toString implementation on View adapters using display name
189fd12 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Ensures source set exists before extending Configuration
59e0def 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Ensures proper ordering of variant binaries
b4aafb2 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Ensure rules only applies to JNI library
c10453d 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Force realize shared library when realizing nativeRuntimeFiles property
5ce49d8 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Force realize main.java.compile path
ae7b6e8 
The Java plugin eagerly creates the compile tasks which circumvent the
task discovery by fully qualified name.

Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Finalize entities that has outgoing dependency bucket after evaluation
715def0 
After project evaluation, Gradle compute a metadata list of all outgoing
artifacts. We need to ensure all outgoing Configuration are present.

Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Add toString implementation on JNI JAR binary
c1b9bb0 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Remove discover reference
0a7c3a5 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Fix duplicated rule for creating JNI JAR binary
3dc73f3 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Fix toString() mismatch
81cad08 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio
Try to solve a flaky issue inside the Gradle dependency engine
8d490ee 
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
@lacasseio lacasseio force-pushed the lacasseio/prepare-discovery-avoidance branch from 39c0ea9 to 8d490ee Compare June 22, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lacasseio lacasseio

Labels

a:enhancement New feature or request in:model-base in:platform-jni in:platform-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lacasseio