Skip to content

fix: use spawn #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AugustinMauroy wants to merge 2 commits into
base: main
Choose a base branch
from
+17 −18
Open

fix: use spawn #362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8be834
fix: use `spawn`
AugustinMauroy Feb 2, 2026
6a1d299
Merge branch 'main' into fix-chalk
AugustinMauroy Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 17 additions & 18 deletions utils/src/remove-dependencies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { execSync } from 'node:child_process';
import { spawn } from 'node:child_process';
Copy link
Contributor

@richiemccoll richiemccoll Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth adding some unit tests with JSSG? (both to confirm the execSync error and the expected spawn behaviour`?)

Copy link
Member Author

@AugustinMauroy AugustinMauroy Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in next pr, because now it's just a patch. also codemod team propose to use json ast on package.json to remove dep & then run install command. I'm going to explore that.

import { existsSync, readFileSync, writeFileSync } from 'node:fs';

/**
Expand Down Expand Up @@ -91,24 +91,23 @@ function detectPackageManager(): 'npm' | 'yarn' | 'pnpm' {
function runPackageManagerInstall(
packageManager: 'npm' | 'yarn' | 'pnpm',
): void {
try {
console.log(`Running ${packageManager} install to update dependencies...`);

switch (packageManager) {
case 'npm':
execSync('npm install', { stdio: 'inherit' });
break;
case 'yarn':
execSync('yarn install', { stdio: 'inherit' });
break;
case 'pnpm':
execSync('pnpm install', { stdio: 'inherit' });
break;
}
console.log(`Running ${packageManager} install to update dependencies...`);

console.log(`Successfully updated dependencies with ${packageManager}`);
} catch (error) {
const command = packageManager;
const args = ['install'];

const child = spawn(command, args, { stdio: 'inherit' });

child.on('error', (error) => {
console.error(`Error running ${packageManager} install:`, error);
// Don't throw - dependency removal was successful, install failure shouldn't break the codemod
}
});

child.on('close', (code) => {
if (code === 0) {
console.log(`Successfully updated dependencies with ${packageManager}`);
} else {
console.error(`${packageManager} install exited with code ${code}`);
}
});
}
Loading