feat(`tape-to-node-test`): first draft #296

AugustinMauroy · 2025-12-10T10:50:27Z

Related issue

Close #260

recipes/tape-to-node-test/src/workflow.ts

Co-authored-by: Bruno Rodrigues <swe@brunocroh.com>

recipes/tape-to-node-test/src/workflow.ts

ljharb

(btw the diff would read cleaner if it was "output" instead of "expected", because then "input" would be sorted before "output" instead of the reverse)

some of my comments apply on all the input/expected combos, so i'll post this now before being exhaustive

recipes/tape-to-node-test/tests/new-features/expected.js

recipes/tape-to-node-test/tests/no-callback-args/expected.js

recipes/tape-to-node-test/tests/require-import/expected.js

AugustinMauroy · 2026-01-17T16:19:58Z

(btw the diff would read cleaner if it was "output" instead of "expected", because then "input" would be sorted before "output" instead of the reverse)

some of my comments apply on all the input/expected combos, so i'll post this now before being exhaustive

the input/expect structure isn't chose by us it's the design of the codemod tool

Co-authored-by: Bruno Rodrigues <swe@brunocroh.com>

AugustinMauroy · 2026-01-17T17:18:28Z

@ljharb i had resolved all of your concerns

ljharb

There's a big issue with converting to assert - namely, that tape test suites very intentionally do not terminate at a failed assertion, but node's assert throws (which prevents running the rest of the assertions).

Does the test runner have a non-throwing assertion API?

recipes/tape-to-node-test/README.md

recipes/tape-to-node-test/tests/aliased-import/expected.js

recipes/tape-to-node-test/tests/advanced-assertions/expected.js

recipes/tape-to-node-test/tests/cjs-destructuring/expected.js

recipes/tape-to-node-test/tests/nested-test/expected.js

recipes/tape-to-node-test/tests/new-features/expected.js

recipes/tape-to-node-test/tests/plan-and-end/expected.js

ljharb · 2026-01-19T23:15:16Z

recipes/tape-to-node-test/tests/timeout-non-object/expected.js

+const opts = { skip: false };
+
+test('timeout with variable opts', opts, async (t) => {
+	// TODO: Add timeout: `123` to test options manually;


does the test runner not have an imperative timeout API?

I didn't found it

AugustinMauroy · 2026-01-21T20:16:07Z

that's fine, but can the PR be marked draft in the meantime? a green PR is mergeable, and with this todo i don't think that's accurate.

i have updated the comment but the user have to found a way to change their code because I dunno if we have an equivalent

ljharb · 2026-01-27T06:31:29Z

If there's no equivalent, then probably it doesn't make sense to provide a codemod until there is?

AugustinMauroy · 2026-02-01T15:20:41Z

If there's no equivalent, then probably it doesn't make sense to provide a codemod until there is?

IMO we should warn it on readme and people will be aware and then they know that will change how does it work.
cc @JakobJingleheimer what do you think ?

avivkeller · 2026-02-02T22:05:49Z

recipes/tape-to-node-test/src/workflow.ts

+const ASSERTION_MAPPING: Record<string, string> = {
+	equal: 'strictEqual',
+	notEqual: 'notStrictEqual',
+	strictEqual: 'strictEqual',
+	notStrictEqual: 'notStrictEqual',
+	deepEqual: 'deepStrictEqual',
+	notDeepEqual: 'notDeepStrictEqual',
+	looseEqual: 'equal',
+	notLooseEqual: 'notEqual',
+	ok: 'ok',
+	ifError: 'ifError',
+	error: 'ifError',
+	throws: 'throws',
+	doesNotThrow: 'doesNotThrow',
+	match: 'match',
+	doesNotMatch: 'doesNotMatch',
+	fail: 'fail',
+	same: 'deepStrictEqual',
+	notSame: 'notDeepStrictEqual',
+	// Aliases
+	assert: 'ok',
+	ifErr: 'ifError',
+	iferror: 'ifError',
+	equals: 'strictEqual',
+	isEqual: 'strictEqual',
+	strictEquals: 'strictEqual',
+	is: 'strictEqual',
+	notEquals: 'notStrictEqual',
+	isNotEqual: 'notStrictEqual',
+	doesNotEqual: 'notStrictEqual',
+	isInequal: 'notStrictEqual',
+	notStrictEquals: 'notStrictEqual',
+	isNot: 'notStrictEqual',
+	not: 'notStrictEqual',
+	looseEquals: 'equal',
+	notLooseEquals: 'notEqual',
+	deepEquals: 'deepStrictEqual',
+	isEquivalent: 'deepStrictEqual',
+	notDeepEquals: 'notDeepStrictEqual',
+	notEquivalent: 'notDeepStrictEqual',
+	notDeeply: 'notDeepStrictEqual',
+	isNotDeepEqual: 'notDeepStrictEqual',
+	isNotDeeply: 'notDeepStrictEqual',
+	isNotEquivalent: 'notDeepStrictEqual',
+	isInequivalent: 'notDeepStrictEqual',
+	deepLooseEqual: 'deepEqual',
+	notDeepLooseEqual: 'notDeepEqual',
+};


Suggested change

const ASSERTION_MAPPING: Record<string, string> = {

equal: 'strictEqual',

notEqual: 'notStrictEqual',

strictEqual: 'strictEqual',

notStrictEqual: 'notStrictEqual',

deepEqual: 'deepStrictEqual',

notDeepEqual: 'notDeepStrictEqual',

looseEqual: 'equal',

notLooseEqual: 'notEqual',

ok: 'ok',

ifError: 'ifError',

error: 'ifError',

throws: 'throws',

doesNotThrow: 'doesNotThrow',

match: 'match',

doesNotMatch: 'doesNotMatch',

fail: 'fail',

same: 'deepStrictEqual',

notSame: 'notDeepStrictEqual',

// Aliases

assert: 'ok',

ifErr: 'ifError',

iferror: 'ifError',

equals: 'strictEqual',

isEqual: 'strictEqual',

strictEquals: 'strictEqual',

is: 'strictEqual',

notEquals: 'notStrictEqual',

isNotEqual: 'notStrictEqual',

doesNotEqual: 'notStrictEqual',

isInequal: 'notStrictEqual',

notStrictEquals: 'notStrictEqual',

isNot: 'notStrictEqual',

not: 'notStrictEqual',

looseEquals: 'equal',

notLooseEquals: 'notEqual',

deepEquals: 'deepStrictEqual',

isEquivalent: 'deepStrictEqual',

notDeepEquals: 'notDeepStrictEqual',

notEquivalent: 'notDeepStrictEqual',

notDeeply: 'notDeepStrictEqual',

isNotDeepEqual: 'notDeepStrictEqual',

isNotDeeply: 'notDeepStrictEqual',

isNotEquivalent: 'notDeepStrictEqual',

isInequivalent: 'notDeepStrictEqual',

deepLooseEqual: 'deepEqual',

notDeepLooseEqual: 'notDeepEqual',

};

const ASSERTION_MAPPING = {

equal: 'strictEqual',

notEqual: 'notStrictEqual',

strictEqual: 'strictEqual',

notStrictEqual: 'notStrictEqual',

deepEqual: 'deepStrictEqual',

notDeepEqual: 'notDeepStrictEqual',

looseEqual: 'equal',

notLooseEqual: 'notEqual',

ok: 'ok',

ifError: 'ifError',

error: 'ifError',

throws: 'throws',

doesNotThrow: 'doesNotThrow',

match: 'match',

doesNotMatch: 'doesNotMatch',

fail: 'fail',

same: 'deepStrictEqual',

notSame: 'notDeepStrictEqual',

// Aliases

assert: 'ok',

ifErr: 'ifError',

iferror: 'ifError',

equals: 'strictEqual',

isEqual: 'strictEqual',

strictEquals: 'strictEqual',

is: 'strictEqual',

notEquals: 'notStrictEqual',

isNotEqual: 'notStrictEqual',

doesNotEqual: 'notStrictEqual',

isInequal: 'notStrictEqual',

notStrictEquals: 'notStrictEqual',

isNot: 'notStrictEqual',

not: 'notStrictEqual',

looseEquals: 'equal',

notLooseEquals: 'notEqual',

deepEquals: 'deepStrictEqual',

isEquivalent: 'deepStrictEqual',

notDeepEquals: 'notDeepStrictEqual',

notEquivalent: 'notDeepStrictEqual',

notDeeply: 'notDeepStrictEqual',

isNotDeepEqual: 'notDeepStrictEqual',

isNotDeeply: 'notDeepStrictEqual',

isNotEquivalent: 'notDeepStrictEqual',

isInequivalent: 'notDeepStrictEqual',

deepLooseEqual: 'deepEqual',

notDeepLooseEqual: 'notDeepEqual',

};

The type here can be inferred

avivkeller · 2026-02-02T22:09:46Z

recipes/tape-to-node-test/src/workflow.ts

+		console.warn(
+			`[Codemod] Warning: ${methodName} at ${fileName}:${line}:${column} has no direct equivalent in node:test. Please migrate manually.`,
+		);


cc @nodejs/test_runner a onFailure (perhaps afterFail, keeping the naming similar) handler is a pretty neat feature for us to include.

Also, onFinish -> after, right?, or does after not run on the completion of the test it's created in?

avivkeller · 2026-02-02T22:11:53Z

recipes/tape-to-node-test/src/workflow.ts

+			case 'true':
+				if (func) edits.push(func.replace('assert.ok'));
+				break;
+			case 'false':
+				if (args) {
+					const val = args.child(1);
+					if (val) {
+						edits.push({
+							startPos: val.range().start.index,
+							endPos: val.range().start.index,
+							insertedText: '!',
+						});
+						if (func) edits.push(func.replace('assert.ok'));
+					}
+				}
+				break;


For aliases, just add another case statement to the previous part (see my other comments)

avivkeller · 2026-02-02T22:12:17Z

recipes/tape-to-node-test/src/workflow.ts

+		}
+
+		switch (method.toLowerCase()) {
+			case 'notok':


Suggested change

case 'notok':

case 'notok':

case 'false':

avivkeller · 2026-02-02T22:13:38Z

recipes/tape-to-node-test/src/workflow.ts

+			case 'pass':
+				if (args) {
+					// Insert 'true' as first arg
+					// args text is like "('msg')" or "()"
+					const openParen = args.child(0);
+					if (openParen) {
+						edits.push({
+							startPos: openParen.range().end.index,
+							endPos: openParen.range().end.index,
+							insertedText: args.children().length > 2 ? 'true, ' : 'true',
+						});
+						if (func) edits.push(func.replace('assert.ok'));
+					}
+				}
+				break;


Our assertions don't work this way, as the message will not be the same. Therefore, this isn't an exact change. These statements should rather be removed entirely.

avivkeller · 2026-02-02T22:14:41Z

recipes/tape-to-node-test/src/workflow.ts

+			case 'plan':
+				break;


Let's put this at the end, for ease of reading

avivkeller · 2026-02-02T22:15:33Z

recipes/tape-to-node-test/src/workflow.ts

+	for (const call of lifecycleCalls) {
+		const { line, column } = call.range().start;
+		const fileName = root.filename();
+		const methodName =
+			call.field('function')?.field('property')?.text() || 'lifecycle method';
+
+		console.warn(
+			`[Codemod] Warning: ${methodName} at ${fileName}:${line}:${column} has no direct equivalent in node:test. Please migrate manually.`,
+		);
+
+		const lines = call.text().split(/\r?\n/);
+		const newText = lines
+			.map((line, i) => (i === 0 ? `// TODO: ${line}` : `// ${line}`))
+			.join(EOL);
+		edits.push(call.replace(newText));
+	}


I see no reason to handle these separately from the rest in transformAssertions. Can't this logic go in the switch statement?

avivkeller · 2026-02-02T22:15:47Z

recipes/tape-to-node-test/src/workflow.ts

+ * @param testCall the AST node of the test function call
+ * @param useDone whether to use the done callback for ending tests
+ */
+function transformAssertions(


This transforms methods, not just assertions

AugustinMauroy added 14 commits December 10, 2025 11:47

feat(tape-to-node-test): first draft

0832a90

fix: use workflow convention

527acf4

fix: use EOL

c5ca0a5

chore: update readme

59cf844

feat(tape-to-node-test): support dynamic import

af14a96

feat(tape-to-node-test): support more cases

f665ea8

fix: code format

08e74b0

feat(tape-to-node-test): support timeout

e51e443

feat(tape-to-node-test): improve

7cd866b

fix: linting/issue

506db48

test,fix: handling of timeout

256c540

Delete index.ts

a6caff6

Merge branch 'main' into tape-to-node-test

15c63ec

remove dep

c0037e1

AugustinMauroy marked this pull request as ready for review December 15, 2025 19:28

AugustinMauroy requested review from a team and ljharb December 15, 2025 19:28

AugustinMauroy added the awaiting reviewer Author has responded and needs action from the reviewer label Dec 15, 2025

brunocroh reviewed Dec 18, 2025

View reviewed changes

recipes/tape-to-node-test/src/workflow.ts Outdated Show resolved Hide resolved

recipes/tape-to-node-test/src/workflow.ts Show resolved Hide resolved

recipes/tape-to-node-test/src/workflow.ts Outdated Show resolved Hide resolved

recipes/tape-to-node-test/src/workflow.ts Show resolved Hide resolved

AugustinMauroy and others added 2 commits December 18, 2025 22:35

Apply suggestions from code review

5b9ce43

Co-authored-by: Bruno Rodrigues <swe@brunocroh.com>

fix: code style

5e5d232

brunocroh reviewed Jan 6, 2026

View reviewed changes

recipes/tape-to-node-test/src/workflow.ts Show resolved Hide resolved

ljharb reviewed Jan 7, 2026

View reviewed changes

recipes/tape-to-node-test/tests/new-features/expected.js Show resolved Hide resolved

recipes/tape-to-node-test/tests/no-callback-args/expected.js Outdated Show resolved Hide resolved

recipes/tape-to-node-test/tests/require-import/expected.js Outdated Show resolved Hide resolved

brunocroh added awaiting author Reviewer has requested something from the author and removed awaiting reviewer Author has responded and needs action from the reviewer labels Jan 9, 2026

AugustinMauroy and others added 4 commits January 17, 2026 17:20

Update recipes/tape-to-node-test/src/workflow.ts

8e0e92c

Co-authored-by: Bruno Rodrigues <swe@brunocroh.com>

better async cb handling

630c116

wip

654294a

handle test and plan

ddf833a

update

bfcb5eb

AugustinMauroy added awaiting reviewer Author has responded and needs action from the reviewer and removed awaiting author Reviewer has requested something from the author labels Jan 17, 2026

ljharb reviewed Jan 19, 2026

View reviewed changes

AugustinMauroy added 3 commits January 21, 2026 21:00

WIP

a44f92e

improve async/sync handling

fc28208

update

2630241

avivkeller reviewed Feb 2, 2026

View reviewed changes

Uh oh!

feat(tape-to-node-test): first draft #296

Are you sure you want to change the base?

feat(tape-to-node-test): first draft #296

Uh oh!

Conversation

AugustinMauroy commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issue

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ljharb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AugustinMauroy commented Jan 17, 2026

Uh oh!

AugustinMauroy commented Jan 17, 2026

Uh oh!

ljharb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AugustinMauroy commented Jan 21, 2026

Uh oh!

ljharb commented Jan 27, 2026

Uh oh!

AugustinMauroy commented Feb 1, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat(`tape-to-node-test`): first draft #296

feat(`tape-to-node-test`): first draft #296

AugustinMauroy commented Dec 10, 2025 •

edited

Loading