Skip to content

feat(DEP0106): migrate from crypto.createCipher & crypto.createDecipher #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AugustinMauroy wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat(DEP0106): migrate from crypto.createCipher & crypto.createDecipher #265

AugustinMauroy wants to merge 10 commits into from

Conversation

@AugustinMauroy
Copy link
Member

@AugustinMauroy AugustinMauroy commented Nov 4, 2025

Description

  • It's the only EOL between v20 to 22 It's mean after this pr we will hable to create @nodejs/v20-to-v22
  • the name of the codemod doesn't look good to me need to found something bettert

Related issue

close #264

@AugustinMauroy AugustinMauroy added awaiting reviewer Author has responded and needs action from the reviewer dep:v22 Migration handles deprecation introduced in node v22 labels Nov 4, 2025
@brunocroh brunocroh self-requested a review December 13, 2025 14:04
avivkeller
avivkeller reviewed Dec 18, 2025
View reviewed changes
@JakobJingleheimer JakobJingleheimer added this to the 20.x → 22.x milestone Jan 25, 2026
@JakobJingleheimer JakobJingleheimer changed the title feat(crypto-createcipheriv-migration): introduce feat(DEP0106): migrate from node:crypto.createCipher & node:crypto.createDecipher Jan 25, 2026
@JakobJingleheimer JakobJingleheimer requested review from tniessen and removed request for tniessen January 25, 2026 17:41
@JakobJingleheimer
Copy link
Member

JakobJingleheimer commented Jan 25, 2026 •
edited
Loading

@nodejs/crypto I'm not familiar with this part of node. could you check that the input and expected test fixtures are accurate?

@JakobJingleheimer JakobJingleheimer changed the title feat(DEP0106): migrate from node:crypto.createCipher & node:crypto.createDecipher feat(DEP0106): migrate from crypto.createCipher & crypto.createDecipher Jan 25, 2026
JakobJingleheimer
JakobJingleheimer approved these changes Jan 25, 2026
View reviewed changes
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me! I'd like someone from the crypto team to take a look at the before & after test fixtures though before landing this.

AugustinMauroy and others added 2 commits February 2, 2026 10:55
@AugustinMauroy
Merge branch 'main' into augustin/DEP-0106
f7e7ecc
@AugustinMauroy @JakobJingleheimer
Update workflow.ts
ae6040b 
Co-Authored-By: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
@JakobJingleheimer JakobJingleheimer added awaiting author Reviewer has requested something from the author awaiting reviewer Author has responded and needs action from the reviewer and removed awaiting reviewer Author has responded and needs action from the reviewer labels Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@avivkeller avivkeller avivkeller approved these changes

@brunocroh brunocroh Awaiting requested review from brunocroh

Assignees

No one assigned

Labels

awaiting author Reviewer has requested something from the author awaiting reviewer Author has responded and needs action from the reviewer dep:v22 Migration handles deprecation introduced in node v22

Projects

None yet

Milestone

20.x → 22.x

Development

Successfully merging this pull request may close these issues.

sepc: createCipher-to-createCipheriv

3 participants

@AugustinMauroy @JakobJingleheimer @avivkeller